From 112f563e1879ab73853fed9d875f45d96d5990fd Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Tue, 26 Jul 2016 17:11:29 +0200 Subject: [PATCH] greybus: operation: fix broken response tracepoint The response-received tracepoint is currently broken. Instead of parsing the received message header it was tracing a bunch of zeroed fields from an uninitialised response buffer. Fix this by moving the tracepoint after were the response buffer is initialised. Fixes: 7cb496e6890e ("greybus: tracing: fix message traces") Reviewed-by: Viresh Kumar Reviewed-by: Bryan O'Donoghue Signed-off-by: Johan Hovold Reviewed-by: Alex Elder Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/operation.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/operation.c b/drivers/staging/greybus/operation.c index e26b1e118545..b9692b750978 100644 --- a/drivers/staging/greybus/operation.c +++ b/drivers/staging/greybus/operation.c @@ -974,7 +974,6 @@ static void gb_connection_recv_response(struct gb_connection *connection, errno = -EMSGSIZE; } } - trace_gb_message_recv_response(operation->response); /* We must ignore the payload if a bad status is returned */ if (errno) @@ -983,6 +982,9 @@ static void gb_connection_recv_response(struct gb_connection *connection, /* The rest will be handled in work queue context */ if (gb_operation_result_set(operation, errno)) { memcpy(message->buffer, data, size); + + trace_gb_message_recv_response(message); + queue_work(gb_operation_completion_wq, &operation->work); } -- 2.20.1