From 9130880a1c2de115d4a3af0f78b2a437a77a1b7e Mon Sep 17 00:00:00 2001 From: Jean Delvare Date: Fri, 23 Jan 2015 10:27:03 +0100 Subject: [PATCH] hwmon: (jc42) Allow negative hysteresis temperatures The driver supports negative high and critical limits, it can return negative hysteresis values, so there is no good reason to not let the user write negative hysteresis values. Signed-off-by: Jean Delvare Cc: Guenter Roeck Signed-off-by: Guenter Roeck --- drivers/hwmon/jc42.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c index a46cb65cacb5..996bdfd5cf25 100644 --- a/drivers/hwmon/jc42.c +++ b/drivers/hwmon/jc42.c @@ -304,15 +304,16 @@ static ssize_t set_temp_crit_hyst(struct device *dev, const char *buf, size_t count) { struct jc42_data *data = dev_get_drvdata(dev); - unsigned long val; + long val; int diff, hyst; int err; int ret = count; - if (kstrtoul(buf, 10, &val) < 0) + if (kstrtol(buf, 10, &val) < 0) return -EINVAL; - val = clamp_val(val, 0, JC42_TEMP_MAX); + val = clamp_val(val, (data->extended ? JC42_TEMP_MIN_EXTENDED : + JC42_TEMP_MIN) - 6000, JC42_TEMP_MAX); diff = jc42_temp_from_reg(data->temp[t_crit]) - val; hyst = 0; -- 2.20.1