tests: Make ovsdb-server add-db/remove-db test faster and more reliable.
authorBen Pfaff <blp@nicira.com>
Mon, 16 Sep 2013 22:03:55 +0000 (15:03 -0700)
committerBen Pfaff <blp@nicira.com>
Mon, 16 Sep 2013 22:07:35 +0000 (15:07 -0700)
commit32643a6a2d410099035b413924f3f824d6fbe034
tree5db29a3e6dd2fdbaa31430a5d13223b1108cfd39
parent1a782d9d8d1663ef88461f5d76b34924d8fc03f1
tests: Make ovsdb-server add-db/remove-db test faster and more reliable.

Until now, the "ovsdb-server/add-db and remove-db with --monitor" test
killed ovsdb-server with SIGSEGV twice.  Each time, the "--monitor" option
caused the supervisor process to restart the child, but the second time it
incurred a 10-second delay intended to prevent the daemon from wasting CPU
time by restarting itself and dying again very quickly in a loop.  This
made the test take over 10 seconds to execute.  It also made it
occasionally fail because the OVS_WAIT_UNTIL check waits at most
approximately 10 seconds before it decides that the condition that it is
testing for will never occur.

This commit fixes the problem by breaking the test into two tests, each of
which kills ovsdb-server with SIGSEGV only once.

Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Ethan Jackson <ethan@nicira.com>
tests/ovsdb-server.at