datapath: Fix IP ID setting.
authorJarno Rajahalme <jarno.rajahalme@nsn.com>
Mon, 25 Mar 2013 19:03:38 +0000 (21:03 +0200)
committerJesse Gross <jesse@nicira.com>
Wed, 27 Mar 2013 01:26:57 +0000 (18:26 -0700)
commit32664c36ab505b219baea847f5430b7a86f80d0a
treed97a1bd3659d34ba0536ab4e3f511a0e139ecbb5
parentbe8b93b0bcfdd91a34f6aee575cd608d9c2bff9e
datapath: Fix IP ID setting.

Eliminate the extra call to ip_select_ident(), and place the
__ip_select_ident() call where the ip_select_ident() call was.
This fixes two problems: Before, the call to ip_select_ident() did
always zero out the value set earlier by __ip_select_ident().  Also,
when __ip_select_ident() was called before setting the iph->daddr,
ident calculation was possibly based on uninitialized data (but as
the result was masked by the later call to ip_select_ident() it was
not visible).

Signed-off-by: Jarno Rajahalme <jarno.rajahalme@nsn.com>
Signed-off-by: Jesse Gross <jesse@nicira.com>
datapath/tunnel.c