Always use valid ids pointer in dec_ttl_cnt_ids_from_openflow()
authorSimon Horman <horms@verge.net.au>
Mon, 3 Jun 2013 05:46:30 +0000 (14:46 +0900)
committerBen Pfaff <blp@nicira.com>
Tue, 4 Jun 2013 17:26:00 +0000 (10:26 -0700)
commit7dc070abb344e9183ca0b78b7146e1cbfbd5d03c
treec5fc76aae761d88348a7101f804fb372bfb42066
parent6801651803de64a99779492e177e203d0057e134
Always use valid ids pointer in dec_ttl_cnt_ids_from_openflow()

Always update the ids pointer after calling ofpbuf_put()
to ensure that it is valid when accessed.

During testing a case came up where the call to ofpbuf_put() in the
for (i = 0; i < ids->n_controllers; i++) loop would cause the underlying
buffer to be reallocated. This resulted in ids->n_controllers being an
incorrect value, the loop continuing on longer than desired and finally a
segmentation fault.

Reported-by: Joe Stringer <joe@wand.net.nz>
Signed-off-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Ben Pfaff <blp@nicira.com>
lib/ofp-actions.c