ofproto-dpif: Always un-wildcard fields that are being set.
authorJustin Pettit <jpettit@nicira.com>
Sat, 3 Aug 2013 04:17:31 +0000 (21:17 -0700)
committerJustin Pettit <jpettit@nicira.com>
Sat, 3 Aug 2013 07:08:49 +0000 (00:08 -0700)
commit983162be835d9e24b6c41e28dc2b310b139e9b54
tree0ff35ab77d40d64ab205585c82bc24845e1f9bcf
parent5b12e2ae1d2519c52c08d9b303f9e2decdecb700
ofproto-dpif: Always un-wildcard fields that are being set.

The ODP library has an optimization to not set a header if the field was
not changed, regardless of whether an action to set the field was
present.  That library is also responsible for un-wildcarding fields
that are bieng modified.  This leads to a problem where a packet matches
a flow that updates a field, but that particular packet's field already
has that value.  As such, an overly loose megaflow will be generated
that doesn't match on that field and the actions won't update it.  A
second packet that should have the field set will match that flow and
will not be modified.

This commit changes the behavior to always un-wildcard fields that are
being modified.  Since the ODP library updates the entire header if a
field in it is modified, and all those fields will be un-wildcarded, the
generated flows may be different.  However, they should be correct.

Bug #18946.

Reported-by: Jesse Gross <jesse@nicira.com>
Signed-off-by: Justin Pettit <jpettit@nicira.com>
Acked-by: Ben Pfaff <blp@nicira.com>
lib/multipath.c
lib/nx-match.c
lib/nx-match.h
ofproto/ofproto-dpif.c
tests/ofproto-dpif.at