tests: Make ovsdb-server add/remove remote test faster and more reliable.
authorAlex Wang <alexw@nicira.com>
Tue, 15 Oct 2013 05:12:59 +0000 (22:12 -0700)
committerBen Pfaff <blp@nicira.com>
Tue, 15 Oct 2013 05:23:44 +0000 (22:23 -0700)
commitb1387877f75b1d9c9112e365364a916416b308fd
treee85b0461ac87ee1b269f2f9c58a35e4ed85c8b83
parentd8c0e581f94f03d577b5730a6b2733876286c7c3
tests: Make ovsdb-server add/remove remote test faster and more reliable.

Until now, the "ovsdb-server/add-remote and remove-remote with --monitor"
test killed ovsdb-server with SIGSEGV twice.  Each time, the "--monitor"
option caused the supervisor process to restart the child, but the second
time it incurred a 10-second delay intended to prevent the daemon from
wasting CPU time by restarting itself and dying again very quickly in a
loop.  This made the test take over 10 seconds to execute.  It also made
it occasionally fail because the OVS_WAIT_UNTIL check waits at most
approximately 10 seconds before it decides that the condition that it is
testing for will never occur.

This commit fixes the problem by breaking the test into two tests, each of
which kills ovsdb-server with SIGSEGV only once.

Signed-off-by: Alex Wang <alexw@nicira.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
tests/ovsdb-server.at