datapath: Relax set header validation.
authorJesse Gross <jesse@nicira.com>
Fri, 3 Aug 2012 01:22:38 +0000 (18:22 -0700)
committerJesse Gross <jesse@nicira.com>
Sat, 4 Aug 2012 02:29:40 +0000 (19:29 -0700)
commite353e467f08fdcad56cabf6ace93101e7174394d
tree4398fa1e5e3c80ccf9fb2d710e840892712de8d3
parentc4610f3c889f838f051cab4c7fb0c3b5fe715a41
datapath: Relax set header validation.

When installing a flow with an action to set a particular field we
need to validate that the packets that are part of the flow actually
contain that header.  With IP we use zeroed addresses and with TCP/UDP
the check is for zeroed ports.  This check is overly broad and can catch
packets like DHCP requests that have a zero source address in a
legitimate header.  This changes the check to look for a zeroed protocol
number for IP or for both ports be zero for TCP/UDP before considering
the header to not exist.

Bug #12769

Reported-by: Ethan Jackson <ethan@nicira.com>
Signed-off-by: Jesse Gross <jesse@nicira.com>
Acked-by: Pravin B Shelar <pshelar@nicira.com>
datapath/datapath.c
lib/odp-util.c