ofproto-dpif: Ignore non-packet field masks during flow revalidation
authorAndy Zhou <azhou@nicira.com>
Wed, 11 Dec 2013 07:32:51 +0000 (23:32 -0800)
committerAndy Zhou <azhou@nicira.com>
Wed, 11 Dec 2013 21:08:48 +0000 (13:08 -0800)
commiteaae2be6eb9ccf40762d1493a67420717d510b88
treece70010d1f25205166488c89f20e9f1131173d19
parent97e955545d87fabab14e5f5d90276f8943e7011d
ofproto-dpif: Ignore non-packet field masks during flow revalidation

Commit bcd2633a5be(ofproto-dpif: Store relevant fields for wildcarding
in facet) implements flow revalidation by comparing the newly looked
up flow mask with that of the existing facet.

The non-packet fields, such as register masks, are always cleared
by xlate_actions in the masks stored within facets, but they are not
cleared in the newly looked up flow masks, causing otherwise valid
flows to be declared as invalid flows and be removed from the datapath.

This patch provides a fix. I was able to verify the fix on a system set
up by Ying Chen where the bug can be reproduced.

Bug #21680
Reported by: Ying Chen <yingchen@vmware.com>

Acked-by: Justin Pettit <jpettit@nicira.com>
Signed-off-by: Andy Zhou <azhou@nicira.com>
lib/flow.c
lib/flow.h
ofproto/ofproto-dpif-xlate.c
ofproto/ofproto-dpif.c