2 * Copyright (c) 2009, 2010, 2011, 2012 Nicira, Inc.
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at:
8 * http://www.apache.org/licenses/LICENSE-2.0
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
17 /* "White box" tests for classifier.
19 * With very few exceptions, these tests obtain complete coverage of every
20 * basic block and every branch in the classifier implementation, e.g. a clean
21 * report from "gcov -b". (Covering the exceptions would require finding
22 * collisions in the hash function used for flow data, etc.)
24 * This test should receive a clean report from "valgrind --leak-check=full":
25 * it frees every heap block that it allocates.
29 #include "classifier.h"
32 #include "byte-order.h"
33 #include "command-line.h"
37 #include "unaligned.h"
42 /* Fields in a rule. */
44 /* struct flow all-caps */ \
45 /* member name name */ \
46 /* ----------- -------- */ \
47 CLS_FIELD(tunnel.tun_id, TUN_ID) \
48 CLS_FIELD(metadata, METADATA) \
49 CLS_FIELD(nw_src, NW_SRC) \
50 CLS_FIELD(nw_dst, NW_DST) \
51 CLS_FIELD(in_port, IN_PORT) \
52 CLS_FIELD(vlan_tci, VLAN_TCI) \
53 CLS_FIELD(dl_type, DL_TYPE) \
54 CLS_FIELD(tp_src, TP_SRC) \
55 CLS_FIELD(tp_dst, TP_DST) \
56 CLS_FIELD(dl_src, DL_SRC) \
57 CLS_FIELD(dl_dst, DL_DST) \
58 CLS_FIELD(nw_proto, NW_PROTO) \
59 CLS_FIELD(nw_tos, NW_DSCP)
63 * (These are also indexed into struct classifier's 'tables' array.) */
65 #define CLS_FIELD(MEMBER, NAME) CLS_F_IDX_##NAME,
71 /* Field information. */
73 int ofs; /* Offset in struct flow. */
74 int len; /* Length in bytes. */
75 const char *name; /* Name (for debugging). */
78 static const struct cls_field cls_fields[CLS_N_FIELDS] = {
79 #define CLS_FIELD(MEMBER, NAME) \
80 { offsetof(struct flow, MEMBER), \
81 sizeof ((struct flow *)0)->MEMBER, \
88 int aux; /* Auxiliary data. */
89 struct cls_rule cls_rule; /* Classifier rule data. */
92 static struct test_rule *
93 test_rule_from_cls_rule(const struct cls_rule *rule)
95 return rule ? CONTAINER_OF(rule, struct test_rule, cls_rule) : NULL;
99 test_rule_destroy(struct test_rule *rule)
102 cls_rule_destroy(&rule->cls_rule);
107 static struct test_rule *make_rule(int wc_fields, unsigned int priority,
109 static void free_rule(struct test_rule *);
110 static struct test_rule *clone_rule(const struct test_rule *);
112 /* Trivial (linear) classifier. */
115 size_t allocated_rules;
116 struct test_rule **rules;
120 tcls_init(struct tcls *tcls)
123 tcls->allocated_rules = 0;
128 tcls_destroy(struct tcls *tcls)
133 for (i = 0; i < tcls->n_rules; i++) {
134 test_rule_destroy(tcls->rules[i]);
141 tcls_is_empty(const struct tcls *tcls)
143 return tcls->n_rules == 0;
146 static struct test_rule *
147 tcls_insert(struct tcls *tcls, const struct test_rule *rule)
151 for (i = 0; i < tcls->n_rules; i++) {
152 const struct cls_rule *pos = &tcls->rules[i]->cls_rule;
153 if (cls_rule_equal(pos, &rule->cls_rule)) {
155 free_rule(tcls->rules[i]);
156 tcls->rules[i] = clone_rule(rule);
157 return tcls->rules[i];
158 } else if (pos->priority < rule->cls_rule.priority) {
163 if (tcls->n_rules >= tcls->allocated_rules) {
164 tcls->rules = x2nrealloc(tcls->rules, &tcls->allocated_rules,
165 sizeof *tcls->rules);
167 if (i != tcls->n_rules) {
168 memmove(&tcls->rules[i + 1], &tcls->rules[i],
169 sizeof *tcls->rules * (tcls->n_rules - i));
171 tcls->rules[i] = clone_rule(rule);
173 return tcls->rules[i];
177 tcls_remove(struct tcls *cls, const struct test_rule *rule)
181 for (i = 0; i < cls->n_rules; i++) {
182 struct test_rule *pos = cls->rules[i];
184 test_rule_destroy(pos);
186 memmove(&cls->rules[i], &cls->rules[i + 1],
187 sizeof *cls->rules * (cls->n_rules - i - 1));
197 match(const struct cls_rule *wild_, const struct flow *fixed)
202 minimatch_expand(&wild_->match, &wild);
203 for (f_idx = 0; f_idx < CLS_N_FIELDS; f_idx++) {
206 if (f_idx == CLS_F_IDX_NW_SRC) {
207 eq = !((fixed->nw_src ^ wild.flow.nw_src)
208 & wild.wc.masks.nw_src);
209 } else if (f_idx == CLS_F_IDX_NW_DST) {
210 eq = !((fixed->nw_dst ^ wild.flow.nw_dst)
211 & wild.wc.masks.nw_dst);
212 } else if (f_idx == CLS_F_IDX_TP_SRC) {
213 eq = !((fixed->tp_src ^ wild.flow.tp_src)
214 & wild.wc.masks.tp_src);
215 } else if (f_idx == CLS_F_IDX_TP_DST) {
216 eq = !((fixed->tp_dst ^ wild.flow.tp_dst)
217 & wild.wc.masks.tp_dst);
218 } else if (f_idx == CLS_F_IDX_DL_SRC) {
219 eq = eth_addr_equal_except(fixed->dl_src, wild.flow.dl_src,
220 wild.wc.masks.dl_src);
221 } else if (f_idx == CLS_F_IDX_DL_DST) {
222 eq = eth_addr_equal_except(fixed->dl_dst, wild.flow.dl_dst,
223 wild.wc.masks.dl_dst);
224 } else if (f_idx == CLS_F_IDX_VLAN_TCI) {
225 eq = !((fixed->vlan_tci ^ wild.flow.vlan_tci)
226 & wild.wc.masks.vlan_tci);
227 } else if (f_idx == CLS_F_IDX_TUN_ID) {
228 eq = !((fixed->tunnel.tun_id ^ wild.flow.tunnel.tun_id)
229 & wild.wc.masks.tunnel.tun_id);
230 } else if (f_idx == CLS_F_IDX_METADATA) {
231 eq = !((fixed->metadata ^ wild.flow.metadata)
232 & wild.wc.masks.metadata);
233 } else if (f_idx == CLS_F_IDX_NW_DSCP) {
234 eq = !((fixed->nw_tos ^ wild.flow.nw_tos) &
235 (wild.wc.masks.nw_tos & IP_DSCP_MASK));
236 } else if (f_idx == CLS_F_IDX_NW_PROTO) {
237 eq = !((fixed->nw_proto ^ wild.flow.nw_proto)
238 & wild.wc.masks.nw_proto);
239 } else if (f_idx == CLS_F_IDX_DL_TYPE) {
240 eq = !((fixed->dl_type ^ wild.flow.dl_type)
241 & wild.wc.masks.dl_type);
242 } else if (f_idx == CLS_F_IDX_IN_PORT) {
243 eq = !((fixed->in_port.ofp_port
244 ^ wild.flow.in_port.ofp_port)
245 & wild.wc.masks.in_port.ofp_port);
257 static struct cls_rule *
258 tcls_lookup(const struct tcls *cls, const struct flow *flow)
262 for (i = 0; i < cls->n_rules; i++) {
263 struct test_rule *pos = cls->rules[i];
264 if (match(&pos->cls_rule, flow)) {
265 return &pos->cls_rule;
272 tcls_delete_matches(struct tcls *cls, const struct cls_rule *target)
276 for (i = 0; i < cls->n_rules; ) {
277 struct test_rule *pos = cls->rules[i];
278 if (!minimask_has_extra(&pos->cls_rule.match.mask,
279 &target->match.mask)) {
282 miniflow_expand(&pos->cls_rule.match.flow, &flow);
283 if (match(target, &flow)) {
284 tcls_remove(cls, pos);
292 static ovs_be32 nw_src_values[] = { CONSTANT_HTONL(0xc0a80001),
293 CONSTANT_HTONL(0xc0a04455) };
294 static ovs_be32 nw_dst_values[] = { CONSTANT_HTONL(0xc0a80002),
295 CONSTANT_HTONL(0xc0a04455) };
296 static ovs_be64 tun_id_values[] = {
298 CONSTANT_HTONLL(UINT64_C(0xfedcba9876543210)) };
299 static ovs_be64 metadata_values[] = {
301 CONSTANT_HTONLL(UINT64_C(0xfedcba9876543210)) };
302 static ofp_port_t in_port_values[] = { OFP_PORT_C(1), OFPP_LOCAL };
303 static ovs_be16 vlan_tci_values[] = { CONSTANT_HTONS(101), CONSTANT_HTONS(0) };
304 static ovs_be16 dl_type_values[]
305 = { CONSTANT_HTONS(ETH_TYPE_IP), CONSTANT_HTONS(ETH_TYPE_ARP) };
306 static ovs_be16 tp_src_values[] = { CONSTANT_HTONS(49362),
307 CONSTANT_HTONS(80) };
308 static ovs_be16 tp_dst_values[] = { CONSTANT_HTONS(6667), CONSTANT_HTONS(22) };
309 static uint8_t dl_src_values[][6] = { { 0x00, 0x02, 0xe3, 0x0f, 0x80, 0xa4 },
310 { 0x5e, 0x33, 0x7f, 0x5f, 0x1e, 0x99 } };
311 static uint8_t dl_dst_values[][6] = { { 0x4a, 0x27, 0x71, 0xae, 0x64, 0xc1 },
312 { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff } };
313 static uint8_t nw_proto_values[] = { IPPROTO_TCP, IPPROTO_ICMP };
314 static uint8_t nw_dscp_values[] = { 48, 0 };
316 static void *values[CLS_N_FIELDS][2];
321 values[CLS_F_IDX_TUN_ID][0] = &tun_id_values[0];
322 values[CLS_F_IDX_TUN_ID][1] = &tun_id_values[1];
324 values[CLS_F_IDX_METADATA][0] = &metadata_values[0];
325 values[CLS_F_IDX_METADATA][1] = &metadata_values[1];
327 values[CLS_F_IDX_IN_PORT][0] = &in_port_values[0];
328 values[CLS_F_IDX_IN_PORT][1] = &in_port_values[1];
330 values[CLS_F_IDX_VLAN_TCI][0] = &vlan_tci_values[0];
331 values[CLS_F_IDX_VLAN_TCI][1] = &vlan_tci_values[1];
333 values[CLS_F_IDX_DL_SRC][0] = dl_src_values[0];
334 values[CLS_F_IDX_DL_SRC][1] = dl_src_values[1];
336 values[CLS_F_IDX_DL_DST][0] = dl_dst_values[0];
337 values[CLS_F_IDX_DL_DST][1] = dl_dst_values[1];
339 values[CLS_F_IDX_DL_TYPE][0] = &dl_type_values[0];
340 values[CLS_F_IDX_DL_TYPE][1] = &dl_type_values[1];
342 values[CLS_F_IDX_NW_SRC][0] = &nw_src_values[0];
343 values[CLS_F_IDX_NW_SRC][1] = &nw_src_values[1];
345 values[CLS_F_IDX_NW_DST][0] = &nw_dst_values[0];
346 values[CLS_F_IDX_NW_DST][1] = &nw_dst_values[1];
348 values[CLS_F_IDX_NW_PROTO][0] = &nw_proto_values[0];
349 values[CLS_F_IDX_NW_PROTO][1] = &nw_proto_values[1];
351 values[CLS_F_IDX_NW_DSCP][0] = &nw_dscp_values[0];
352 values[CLS_F_IDX_NW_DSCP][1] = &nw_dscp_values[1];
354 values[CLS_F_IDX_TP_SRC][0] = &tp_src_values[0];
355 values[CLS_F_IDX_TP_SRC][1] = &tp_src_values[1];
357 values[CLS_F_IDX_TP_DST][0] = &tp_dst_values[0];
358 values[CLS_F_IDX_TP_DST][1] = &tp_dst_values[1];
361 #define N_NW_SRC_VALUES ARRAY_SIZE(nw_src_values)
362 #define N_NW_DST_VALUES ARRAY_SIZE(nw_dst_values)
363 #define N_TUN_ID_VALUES ARRAY_SIZE(tun_id_values)
364 #define N_METADATA_VALUES ARRAY_SIZE(metadata_values)
365 #define N_IN_PORT_VALUES ARRAY_SIZE(in_port_values)
366 #define N_VLAN_TCI_VALUES ARRAY_SIZE(vlan_tci_values)
367 #define N_DL_TYPE_VALUES ARRAY_SIZE(dl_type_values)
368 #define N_TP_SRC_VALUES ARRAY_SIZE(tp_src_values)
369 #define N_TP_DST_VALUES ARRAY_SIZE(tp_dst_values)
370 #define N_DL_SRC_VALUES ARRAY_SIZE(dl_src_values)
371 #define N_DL_DST_VALUES ARRAY_SIZE(dl_dst_values)
372 #define N_NW_PROTO_VALUES ARRAY_SIZE(nw_proto_values)
373 #define N_NW_DSCP_VALUES ARRAY_SIZE(nw_dscp_values)
375 #define N_FLOW_VALUES (N_NW_SRC_VALUES * \
379 N_VLAN_TCI_VALUES * \
385 N_NW_PROTO_VALUES * \
389 get_value(unsigned int *x, unsigned n_values)
391 unsigned int rem = *x % n_values;
397 compare_classifiers(struct classifier *cls, struct tcls *tcls)
399 static const int confidence = 500;
402 assert(classifier_count(cls) == tcls->n_rules);
403 for (i = 0; i < confidence; i++) {
404 struct cls_rule *cr0, *cr1;
408 x = rand () % N_FLOW_VALUES;
409 memset(&flow, 0, sizeof flow);
410 flow.nw_src = nw_src_values[get_value(&x, N_NW_SRC_VALUES)];
411 flow.nw_dst = nw_dst_values[get_value(&x, N_NW_DST_VALUES)];
412 flow.tunnel.tun_id = tun_id_values[get_value(&x, N_TUN_ID_VALUES)];
413 flow.metadata = metadata_values[get_value(&x, N_METADATA_VALUES)];
414 flow.in_port.ofp_port = in_port_values[get_value(&x,
416 flow.vlan_tci = vlan_tci_values[get_value(&x, N_VLAN_TCI_VALUES)];
417 flow.dl_type = dl_type_values[get_value(&x, N_DL_TYPE_VALUES)];
418 flow.tp_src = tp_src_values[get_value(&x, N_TP_SRC_VALUES)];
419 flow.tp_dst = tp_dst_values[get_value(&x, N_TP_DST_VALUES)];
420 memcpy(flow.dl_src, dl_src_values[get_value(&x, N_DL_SRC_VALUES)],
422 memcpy(flow.dl_dst, dl_dst_values[get_value(&x, N_DL_DST_VALUES)],
424 flow.nw_proto = nw_proto_values[get_value(&x, N_NW_PROTO_VALUES)];
425 flow.nw_tos = nw_dscp_values[get_value(&x, N_NW_DSCP_VALUES)];
427 cr0 = classifier_lookup(cls, &flow, NULL);
428 cr1 = tcls_lookup(tcls, &flow);
429 assert((cr0 == NULL) == (cr1 == NULL));
431 const struct test_rule *tr0 = test_rule_from_cls_rule(cr0);
432 const struct test_rule *tr1 = test_rule_from_cls_rule(cr1);
434 assert(cls_rule_equal(cr0, cr1));
435 assert(tr0->aux == tr1->aux);
441 destroy_classifier(struct classifier *cls)
443 struct test_rule *rule, *next_rule;
444 struct cls_cursor cursor;
446 cls_cursor_init(&cursor, cls, NULL);
447 CLS_CURSOR_FOR_EACH_SAFE (rule, next_rule, cls_rule, &cursor) {
448 classifier_remove(cls, &rule->cls_rule);
451 classifier_destroy(cls);
455 check_tables(const struct classifier *cls,
456 int n_tables, int n_rules, int n_dups)
458 const struct cls_table *table;
459 struct test_rule *test_rule;
460 struct cls_cursor cursor;
461 int found_tables = 0;
464 int found_rules2 = 0;
466 HMAP_FOR_EACH (table, hmap_node, &cls->tables) {
467 const struct cls_rule *head;
468 unsigned int max_priority = 0;
469 unsigned int max_count = 0;
471 assert(!hmap_is_empty(&table->rules));
474 HMAP_FOR_EACH (head, hmap_node, &table->rules) {
475 unsigned int prev_priority = UINT_MAX;
476 const struct cls_rule *rule;
478 if (head->priority > max_priority) {
479 max_priority = head->priority;
481 } else if (head->priority == max_priority) {
486 LIST_FOR_EACH (rule, list, &head->list) {
487 assert(rule->priority < prev_priority);
488 assert(rule->priority <= table->max_priority);
490 prev_priority = rule->priority;
493 assert(classifier_find_rule_exactly(cls, rule) == rule);
496 assert(table->max_priority == max_priority);
497 assert(table->max_count == max_count);
500 assert(found_tables == hmap_count(&cls->tables));
501 assert(n_tables == -1 || n_tables == hmap_count(&cls->tables));
502 assert(n_rules == -1 || found_rules == n_rules);
503 assert(n_dups == -1 || found_dups == n_dups);
505 cls_cursor_init(&cursor, cls, NULL);
506 CLS_CURSOR_FOR_EACH (test_rule, cls_rule, &cursor) {
509 assert(found_rules == found_rules2);
512 static struct test_rule *
513 make_rule(int wc_fields, unsigned int priority, int value_pat)
515 const struct cls_field *f;
516 struct test_rule *rule;
519 match_init_catchall(&match);
520 for (f = &cls_fields[0]; f < &cls_fields[CLS_N_FIELDS]; f++) {
521 int f_idx = f - cls_fields;
522 int value_idx = (value_pat & (1u << f_idx)) != 0;
523 memcpy((char *) &match.flow + f->ofs,
524 values[f_idx][value_idx], f->len);
526 if (f_idx == CLS_F_IDX_NW_SRC) {
527 match.wc.masks.nw_src = htonl(UINT32_MAX);
528 } else if (f_idx == CLS_F_IDX_NW_DST) {
529 match.wc.masks.nw_dst = htonl(UINT32_MAX);
530 } else if (f_idx == CLS_F_IDX_TP_SRC) {
531 match.wc.masks.tp_src = htons(UINT16_MAX);
532 } else if (f_idx == CLS_F_IDX_TP_DST) {
533 match.wc.masks.tp_dst = htons(UINT16_MAX);
534 } else if (f_idx == CLS_F_IDX_DL_SRC) {
535 memset(match.wc.masks.dl_src, 0xff, ETH_ADDR_LEN);
536 } else if (f_idx == CLS_F_IDX_DL_DST) {
537 memset(match.wc.masks.dl_dst, 0xff, ETH_ADDR_LEN);
538 } else if (f_idx == CLS_F_IDX_VLAN_TCI) {
539 match.wc.masks.vlan_tci = htons(UINT16_MAX);
540 } else if (f_idx == CLS_F_IDX_TUN_ID) {
541 match.wc.masks.tunnel.tun_id = htonll(UINT64_MAX);
542 } else if (f_idx == CLS_F_IDX_METADATA) {
543 match.wc.masks.metadata = htonll(UINT64_MAX);
544 } else if (f_idx == CLS_F_IDX_NW_DSCP) {
545 match.wc.masks.nw_tos |= IP_DSCP_MASK;
546 } else if (f_idx == CLS_F_IDX_NW_PROTO) {
547 match.wc.masks.nw_proto = UINT8_MAX;
548 } else if (f_idx == CLS_F_IDX_DL_TYPE) {
549 match.wc.masks.dl_type = htons(UINT16_MAX);
550 } else if (f_idx == CLS_F_IDX_IN_PORT) {
551 match.wc.masks.in_port.ofp_port = u16_to_ofp(UINT16_MAX);
557 rule = xzalloc(sizeof *rule);
558 cls_rule_init(&rule->cls_rule, &match, wc_fields ? priority : UINT_MAX);
562 static struct test_rule *
563 clone_rule(const struct test_rule *src)
565 struct test_rule *dst;
567 dst = xmalloc(sizeof *dst);
569 cls_rule_clone(&dst->cls_rule, &src->cls_rule);
574 free_rule(struct test_rule *rule)
576 cls_rule_destroy(&rule->cls_rule);
581 shuffle(unsigned int *p, size_t n)
583 for (; n > 1; n--, p++) {
584 unsigned int *q = &p[rand() % n];
585 unsigned int tmp = *p;
592 shuffle_u32s(uint32_t *p, size_t n)
594 for (; n > 1; n--, p++) {
595 uint32_t *q = &p[rand() % n];
602 /* Classifier tests. */
604 /* Tests an empty classifier. */
606 test_empty(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
608 struct classifier cls;
611 classifier_init(&cls);
613 assert(classifier_is_empty(&cls));
614 assert(tcls_is_empty(&tcls));
615 compare_classifiers(&cls, &tcls);
616 classifier_destroy(&cls);
620 /* Destroys a null classifier. */
622 test_destroy_null(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
624 classifier_destroy(NULL);
627 /* Tests classification with one rule at a time. */
629 test_single_rule(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
631 unsigned int wc_fields; /* Hilarious. */
633 for (wc_fields = 0; wc_fields < (1u << CLS_N_FIELDS); wc_fields++) {
634 struct classifier cls;
635 struct test_rule *rule, *tcls_rule;
638 rule = make_rule(wc_fields,
639 hash_bytes(&wc_fields, sizeof wc_fields, 0), 0);
641 classifier_init(&cls);
644 tcls_rule = tcls_insert(&tcls, rule);
645 classifier_insert(&cls, &rule->cls_rule);
646 check_tables(&cls, 1, 1, 0);
647 compare_classifiers(&cls, &tcls);
649 classifier_remove(&cls, &rule->cls_rule);
650 tcls_remove(&tcls, tcls_rule);
651 assert(classifier_is_empty(&cls));
652 assert(tcls_is_empty(&tcls));
653 compare_classifiers(&cls, &tcls);
656 classifier_destroy(&cls);
661 /* Tests replacing one rule by another. */
663 test_rule_replacement(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
665 unsigned int wc_fields;
667 for (wc_fields = 0; wc_fields < (1u << CLS_N_FIELDS); wc_fields++) {
668 struct classifier cls;
669 struct test_rule *rule1;
670 struct test_rule *rule2;
673 rule1 = make_rule(wc_fields, OFP_DEFAULT_PRIORITY, UINT_MAX);
674 rule2 = make_rule(wc_fields, OFP_DEFAULT_PRIORITY, UINT_MAX);
678 classifier_init(&cls);
680 tcls_insert(&tcls, rule1);
681 classifier_insert(&cls, &rule1->cls_rule);
682 check_tables(&cls, 1, 1, 0);
683 compare_classifiers(&cls, &tcls);
687 tcls_insert(&tcls, rule2);
688 assert(test_rule_from_cls_rule(
689 classifier_replace(&cls, &rule2->cls_rule)) == rule1);
691 check_tables(&cls, 1, 1, 0);
692 compare_classifiers(&cls, &tcls);
694 destroy_classifier(&cls);
699 factorial(int n_items)
704 for (i = 2; i <= n_items; i++) {
719 reverse(int *a, int n)
723 for (i = 0; i < n / 2; i++) {
730 next_permutation(int *a, int n)
734 for (k = n - 2; k >= 0; k--) {
735 if (a[k] < a[k + 1]) {
738 for (l = n - 1; ; l--) {
741 reverse(a + (k + 1), n - (k + 1));
750 /* Tests classification with rules that have the same matching criteria. */
752 test_many_rules_in_one_list (int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
754 enum { N_RULES = 3 };
757 for (n_pris = N_RULES; n_pris >= 1; n_pris--) {
758 int ops[N_RULES * 2];
764 for (i = 1; i < N_RULES; i++) {
765 pris[i] = pris[i - 1] + (n_pris > i);
768 for (i = 0; i < N_RULES * 2; i++) {
774 struct test_rule *rules[N_RULES];
775 struct test_rule *tcls_rules[N_RULES];
776 int pri_rules[N_RULES];
777 struct classifier cls;
782 for (i = 0; i < N_RULES; i++) {
783 rules[i] = make_rule(456, pris[i], 0);
784 tcls_rules[i] = NULL;
788 classifier_init(&cls);
791 for (i = 0; i < ARRAY_SIZE(ops); i++) {
795 if (!tcls_rules[j]) {
796 struct test_rule *displaced_rule;
798 tcls_rules[j] = tcls_insert(&tcls, rules[j]);
799 displaced_rule = test_rule_from_cls_rule(
800 classifier_replace(&cls, &rules[j]->cls_rule));
801 if (pri_rules[pris[j]] >= 0) {
802 int k = pri_rules[pris[j]];
803 assert(displaced_rule != NULL);
804 assert(displaced_rule != rules[j]);
805 assert(pris[j] == displaced_rule->cls_rule.priority);
806 tcls_rules[k] = NULL;
808 assert(displaced_rule == NULL);
810 pri_rules[pris[j]] = j;
812 classifier_remove(&cls, &rules[j]->cls_rule);
813 tcls_remove(&tcls, tcls_rules[j]);
814 tcls_rules[j] = NULL;
815 pri_rules[pris[j]] = -1;
819 for (m = 0; m < N_RULES; m++) {
820 n += tcls_rules[m] != NULL;
822 check_tables(&cls, n > 0, n, n - 1);
824 compare_classifiers(&cls, &tcls);
827 classifier_destroy(&cls);
830 for (i = 0; i < N_RULES; i++) {
833 } while (next_permutation(ops, ARRAY_SIZE(ops)));
834 assert(n_permutations == (factorial(N_RULES * 2) >> N_RULES));
839 count_ones(unsigned long int x)
844 x = zero_rightmost_1bit(x);
852 array_contains(int *array, int n, int value)
856 for (i = 0; i < n; i++) {
857 if (array[i] == value) {
865 /* Tests classification with two rules at a time that fall into the same
866 * table but different lists. */
868 test_many_rules_in_one_table(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
872 for (iteration = 0; iteration < 50; iteration++) {
873 enum { N_RULES = 20 };
874 struct test_rule *rules[N_RULES];
875 struct test_rule *tcls_rules[N_RULES];
876 struct classifier cls;
878 int value_pats[N_RULES];
884 wcf = rand() & ((1u << CLS_N_FIELDS) - 1);
885 value_mask = ~wcf & ((1u << CLS_N_FIELDS) - 1);
886 } while ((1 << count_ones(value_mask)) < N_RULES);
888 classifier_init(&cls);
891 for (i = 0; i < N_RULES; i++) {
892 unsigned int priority = rand();
895 value_pats[i] = rand() & value_mask;
896 } while (array_contains(value_pats, i, value_pats[i]));
898 rules[i] = make_rule(wcf, priority, value_pats[i]);
899 tcls_rules[i] = tcls_insert(&tcls, rules[i]);
900 classifier_insert(&cls, &rules[i]->cls_rule);
902 check_tables(&cls, 1, i + 1, 0);
903 compare_classifiers(&cls, &tcls);
906 for (i = 0; i < N_RULES; i++) {
907 tcls_remove(&tcls, tcls_rules[i]);
908 classifier_remove(&cls, &rules[i]->cls_rule);
911 check_tables(&cls, i < N_RULES - 1, N_RULES - (i + 1), 0);
912 compare_classifiers(&cls, &tcls);
915 classifier_destroy(&cls);
920 /* Tests classification with many rules at a time that fall into random lists
923 test_many_rules_in_n_tables(int n_tables)
925 enum { MAX_RULES = 50 };
930 assert(n_tables < 10);
931 for (i = 0; i < n_tables; i++) {
933 wcfs[i] = rand() & ((1u << CLS_N_FIELDS) - 1);
934 } while (array_contains(wcfs, i, wcfs[i]));
937 for (iteration = 0; iteration < 30; iteration++) {
938 unsigned int priorities[MAX_RULES];
939 struct classifier cls;
943 for (i = 0; i < MAX_RULES; i++) {
944 priorities[i] = i * 129;
946 shuffle(priorities, ARRAY_SIZE(priorities));
948 classifier_init(&cls);
951 for (i = 0; i < MAX_RULES; i++) {
952 struct test_rule *rule;
953 unsigned int priority = priorities[i];
954 int wcf = wcfs[rand() % n_tables];
955 int value_pat = rand() & ((1u << CLS_N_FIELDS) - 1);
956 rule = make_rule(wcf, priority, value_pat);
957 tcls_insert(&tcls, rule);
958 classifier_insert(&cls, &rule->cls_rule);
959 check_tables(&cls, -1, i + 1, -1);
960 compare_classifiers(&cls, &tcls);
963 while (!classifier_is_empty(&cls)) {
964 struct test_rule *rule, *next_rule;
965 struct test_rule *target;
966 struct cls_cursor cursor;
968 target = clone_rule(tcls.rules[rand() % tcls.n_rules]);
970 cls_cursor_init(&cursor, &cls, &target->cls_rule);
971 CLS_CURSOR_FOR_EACH_SAFE (rule, next_rule, cls_rule, &cursor) {
972 classifier_remove(&cls, &rule->cls_rule);
975 tcls_delete_matches(&tcls, &target->cls_rule);
976 compare_classifiers(&cls, &tcls);
977 check_tables(&cls, -1, -1, -1);
981 destroy_classifier(&cls);
987 test_many_rules_in_two_tables(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
989 test_many_rules_in_n_tables(2);
993 test_many_rules_in_five_tables(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
995 test_many_rules_in_n_tables(5);
998 /* Miniflow tests. */
1003 static const uint32_t values[] =
1004 { 0xffffffff, 0xaaaaaaaa, 0x55555555, 0x80000000,
1005 0x00000001, 0xface0000, 0x00d00d1e, 0xdeadbeef };
1007 return values[random_uint32() % ARRAY_SIZE(values)];
1011 choose(unsigned int n, unsigned int *idxp)
1022 init_consecutive_values(int n_consecutive, struct flow *flow,
1025 uint32_t *flow_u32 = (uint32_t *) flow;
1027 if (choose(FLOW_U32S - n_consecutive + 1, idxp)) {
1030 for (i = 0; i < n_consecutive; i++) {
1031 flow_u32[*idxp + i] = random_value();
1040 next_random_flow(struct flow *flow, unsigned int idx)
1042 uint32_t *flow_u32 = (uint32_t *) flow;
1045 memset(flow, 0, sizeof *flow);
1048 if (choose(1, &idx)) {
1052 /* All flows with a small number of consecutive nonzero values. */
1053 for (i = 1; i <= 4; i++) {
1054 if (init_consecutive_values(i, flow, &idx)) {
1059 /* All flows with a large number of consecutive nonzero values. */
1060 for (i = FLOW_U32S - 4; i <= FLOW_U32S; i++) {
1061 if (init_consecutive_values(i, flow, &idx)) {
1066 /* All flows with exactly two nonconsecutive nonzero values. */
1067 if (choose((FLOW_U32S - 1) * (FLOW_U32S - 2) / 2, &idx)) {
1070 for (ofs1 = 0; ofs1 < FLOW_U32S - 2; ofs1++) {
1073 for (ofs2 = ofs1 + 2; ofs2 < FLOW_U32S; ofs2++) {
1074 if (choose(1, &idx)) {
1075 flow_u32[ofs1] = random_value();
1076 flow_u32[ofs2] = random_value();
1084 /* 16 randomly chosen flows with N >= 3 nonzero values. */
1085 if (choose(16 * (FLOW_U32S - 4), &idx)) {
1086 int n = idx / 16 + 3;
1089 for (i = 0; i < n; i++) {
1090 flow_u32[i] = random_value();
1092 shuffle_u32s(flow_u32, FLOW_U32S);
1101 any_random_flow(struct flow *flow)
1103 static unsigned int max;
1105 while (next_random_flow(flow, max)) {
1110 next_random_flow(flow, random_range(max));
1114 toggle_masked_flow_bits(struct flow *flow, const struct flow_wildcards *mask)
1116 const uint32_t *mask_u32 = (const uint32_t *) &mask->masks;
1117 uint32_t *flow_u32 = (uint32_t *) flow;
1120 for (i = 0; i < FLOW_U32S; i++) {
1121 if (mask_u32[i] != 0) {
1125 bit = 1u << random_range(32);
1126 } while (!(bit & mask_u32[i]));
1133 wildcard_extra_bits(struct flow_wildcards *mask)
1135 uint32_t *mask_u32 = (uint32_t *) &mask->masks;
1138 for (i = 0; i < FLOW_U32S; i++) {
1139 if (mask_u32[i] != 0) {
1143 bit = 1u << random_range(32);
1144 } while (!(bit & mask_u32[i]));
1145 mask_u32[i] &= ~bit;
1151 test_miniflow(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
1156 random_set_seed(0xb3faca38);
1157 for (idx = 0; next_random_flow(&flow, idx); idx++) {
1158 const uint32_t *flow_u32 = (const uint32_t *) &flow;
1159 struct miniflow miniflow, miniflow2, miniflow3;
1160 struct flow flow2, flow3;
1161 struct flow_wildcards mask;
1162 struct minimask minimask;
1165 /* Convert flow to miniflow. */
1166 miniflow_init(&miniflow, &flow);
1168 /* Check that the flow equals its miniflow. */
1169 assert(miniflow_get_vid(&miniflow) == vlan_tci_to_vid(flow.vlan_tci));
1170 for (i = 0; i < FLOW_U32S; i++) {
1171 assert(miniflow_get(&miniflow, i) == flow_u32[i]);
1174 /* Check that the miniflow equals itself. */
1175 assert(miniflow_equal(&miniflow, &miniflow));
1177 /* Convert miniflow back to flow and verify that it's the same. */
1178 miniflow_expand(&miniflow, &flow2);
1179 assert(flow_equal(&flow, &flow2));
1181 /* Check that copying a miniflow works properly. */
1182 miniflow_clone(&miniflow2, &miniflow);
1183 assert(miniflow_equal(&miniflow, &miniflow2));
1184 assert(miniflow_hash(&miniflow, 0) == miniflow_hash(&miniflow2, 0));
1185 miniflow_expand(&miniflow2, &flow3);
1186 assert(flow_equal(&flow, &flow3));
1188 /* Check that masked matches work as expected for identical flows and
1191 next_random_flow(&mask.masks, 1);
1192 } while (flow_wildcards_is_catchall(&mask));
1193 minimask_init(&minimask, &mask);
1194 assert(minimask_is_catchall(&minimask)
1195 == flow_wildcards_is_catchall(&mask));
1196 assert(miniflow_equal_in_minimask(&miniflow, &miniflow2, &minimask));
1197 assert(miniflow_equal_flow_in_minimask(&miniflow, &flow2, &minimask));
1198 assert(miniflow_hash_in_minimask(&miniflow, &minimask, 0x12345678) ==
1199 flow_hash_in_minimask(&flow, &minimask, 0x12345678));
1201 /* Check that masked matches work as expected for differing flows and
1203 toggle_masked_flow_bits(&flow2, &mask);
1204 assert(!miniflow_equal_flow_in_minimask(&miniflow, &flow2, &minimask));
1205 miniflow_init(&miniflow3, &flow2);
1206 assert(!miniflow_equal_in_minimask(&miniflow, &miniflow3, &minimask));
1209 miniflow_destroy(&miniflow);
1210 miniflow_destroy(&miniflow2);
1211 miniflow_destroy(&miniflow3);
1212 minimask_destroy(&minimask);
1217 test_minimask_has_extra(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
1219 struct flow_wildcards catchall;
1220 struct minimask minicatchall;
1224 flow_wildcards_init_catchall(&catchall);
1225 minimask_init(&minicatchall, &catchall);
1226 assert(minimask_is_catchall(&minicatchall));
1228 random_set_seed(0x2ec7905b);
1229 for (idx = 0; next_random_flow(&flow, idx); idx++) {
1230 struct flow_wildcards mask;
1231 struct minimask minimask;
1234 minimask_init(&minimask, &mask);
1235 assert(!minimask_has_extra(&minimask, &minimask));
1236 assert(minimask_has_extra(&minicatchall, &minimask)
1237 == !minimask_is_catchall(&minimask));
1238 if (!minimask_is_catchall(&minimask)) {
1239 struct minimask minimask2;
1241 wildcard_extra_bits(&mask);
1242 minimask_init(&minimask2, &mask);
1243 assert(minimask_has_extra(&minimask2, &minimask));
1244 assert(!minimask_has_extra(&minimask, &minimask2));
1245 minimask_destroy(&minimask2);
1248 minimask_destroy(&minimask);
1251 minimask_destroy(&minicatchall);
1255 test_minimask_combine(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
1257 struct flow_wildcards catchall;
1258 struct minimask minicatchall;
1262 flow_wildcards_init_catchall(&catchall);
1263 minimask_init(&minicatchall, &catchall);
1264 assert(minimask_is_catchall(&minicatchall));
1266 random_set_seed(0x181bf0cd);
1267 for (idx = 0; next_random_flow(&flow, idx); idx++) {
1268 struct minimask minimask, minimask2, minicombined;
1269 struct flow_wildcards mask, mask2, combined, combined2;
1270 uint32_t storage[FLOW_U32S];
1274 minimask_init(&minimask, &mask);
1276 minimask_combine(&minicombined, &minimask, &minicatchall, storage);
1277 assert(minimask_is_catchall(&minicombined));
1279 any_random_flow(&flow2);
1280 mask2.masks = flow2;
1281 minimask_init(&minimask2, &mask2);
1283 minimask_combine(&minicombined, &minimask, &minimask2, storage);
1284 flow_wildcards_and(&combined, &mask, &mask2);
1285 minimask_expand(&minicombined, &combined2);
1286 assert(flow_wildcards_equal(&combined, &combined2));
1288 minimask_destroy(&minimask);
1289 minimask_destroy(&minimask2);
1292 minimask_destroy(&minicatchall);
1295 static const struct command commands[] = {
1296 /* Classifier tests. */
1297 {"empty", 0, 0, test_empty},
1298 {"destroy-null", 0, 0, test_destroy_null},
1299 {"single-rule", 0, 0, test_single_rule},
1300 {"rule-replacement", 0, 0, test_rule_replacement},
1301 {"many-rules-in-one-list", 0, 0, test_many_rules_in_one_list},
1302 {"many-rules-in-one-table", 0, 0, test_many_rules_in_one_table},
1303 {"many-rules-in-two-tables", 0, 0, test_many_rules_in_two_tables},
1304 {"many-rules-in-five-tables", 0, 0, test_many_rules_in_five_tables},
1306 /* Miniflow and minimask tests. */
1307 {"miniflow", 0, 0, test_miniflow},
1308 {"minimask_has_extra", 0, 0, test_minimask_has_extra},
1309 {"minimask_combine", 0, 0, test_minimask_combine},
1315 main(int argc, char *argv[])
1317 set_program_name(argv[0]);
1319 run_command(argc - 1, argv + 1, commands);