Move login plugin configuration to its own module

[cascardo/ipsilon.git] / ipsilon / admin / common.py

diff --git a/ipsilon/admin/common.py b/ipsilon/admin/common.py
index 6e36669..0a46797 100755 (executable)
--- a/ipsilon/admin/common.py
+++ b/ipsilon/admin/common.py
@@ -17,30 +17,19 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+import cherrypy
 from ipsilon.util.data import Store
 from ipsilon.util.page import Page
-from ipsilon.util.user import UserSession
-import cherrypy
-from ipsilon.login.common import FACILITY as LOGIN_FACILITY
-
-
-def admin_protect(fn):
-
-    def check(*args, **kwargs):
-        if UserSession().get_user().is_admin:
-            return fn(*args, **kwargs)
+from ipsilon.util.page import admin_protect
 
-        raise cherrypy.HTTPError(403)
 
-    return check
+class AdminPluginPage(Page):
 
-
-class LoginPluginPage(Page):
-
-    def __init__(self, obj, site, baseurl):
-        super(LoginPluginPage, self).__init__(site)
+    def __init__(self, obj, site, baseurl, facility):
+        super(AdminPluginPage, self).__init__(site)
         self._obj = obj
         self.url = '%s/%s' % (baseurl, obj.name)
+        self.facility = facility
 
         # Get the defaults
         self.plugin_config = obj.get_config_desc()
@@ -53,9 +42,10 @@ class LoginPluginPage(Page):
 
     @admin_protect
     def GET(self, *args, **kwargs):
-        return self._template('admin/login_plugin.html',
+        return self._template('admin/plugin_config.html',
                               title='%s plugin' % self._obj.name,
-                              name='admin_login_%s_form' % self._obj.name,
+                              name='admin_%s_%s_form' % (self.facility,
+                                                         self._obj.name),
                               action=self.url,
                               options=self.plugin_config)
 
@@ -77,7 +67,7 @@ class LoginPluginPage(Page):
             # First we try to save in the database
             try:
                 store = Store()
-                store.save_plugin_config(LOGIN_FACILITY,
+                store.save_plugin_config(self.facility,
                                          self._obj.name, new_values)
                 message = "New configuration saved."
                 message_type = "success"
@@ -90,11 +80,12 @@ class LoginPluginPage(Page):
                 self._obj.set_config_value(name, value)
                 self.plugin_config[name][2] = value
 
-        return self._template('admin/login_plugin.html',
+        return self._template('admin/plugin_config.html',
                               message=message,
                               message_type=message_type,
                               title='%s plugin' % self._obj.name,
-                              name='admin_login_%s_form' % self._obj.name,
+                              name='admin_%s_%s_form' % (self.facility,
+                                                         self._obj.name),
                               action=self.url,
                               options=self.plugin_config)
 
@@ -105,26 +96,11 @@ class LoginPluginPage(Page):
             return op(*args, **kwargs)
 
 
-class LoginPlugins(Page):
-    def __init__(self, site, baseurl):
-        super(LoginPlugins, self).__init__(site)
-        self.url = '%s/login' % baseurl
-
-        for plugin in self._site[LOGIN_FACILITY]['available']:
-            cherrypy.log.error('Admin login plugin: %s' % plugin)
-            obj = self._site[LOGIN_FACILITY]['available'][plugin]
-            self.__dict__[plugin] = LoginPluginPage(obj, self._site, self.url)
-
-
 class Admin(Page):
 
-    def __init__(self, *args, **kwargs):
-        super(Admin, self).__init__(*args, **kwargs)
-        self.url = '%s/admin' % self.basepath
-        self.login = LoginPlugins(self._site, self.url)
+    def __init__(self, site, mount):
+        super(Admin, self).__init__(site)
+        self.url = '%s/%s' % (self.basepath, mount)
 
     def root(self, *args, **kwargs):
-        login_plugins = self._site[LOGIN_FACILITY]
-        return self._template('admin/index.html', title='Administration',
-                              available=login_plugins['available'],
-                              enabled=login_plugins['enabled'])
+        return self._template('admin/index.html', title='Configuration')