perf hists: Fix children sort key behavior
[cascardo/linux.git] / tools / perf / ui / hist.c
1 #include <math.h>
2 #include <linux/compiler.h>
3
4 #include "../util/hist.h"
5 #include "../util/util.h"
6 #include "../util/sort.h"
7 #include "../util/evsel.h"
8
9 /* hist period print (hpp) functions */
10
11 #define hpp__call_print_fn(hpp, fn, fmt, ...)                   \
12 ({                                                              \
13         int __ret = fn(hpp, fmt, ##__VA_ARGS__);                \
14         advance_hpp(hpp, __ret);                                \
15         __ret;                                                  \
16 })
17
18 static int __hpp__fmt(struct perf_hpp *hpp, struct hist_entry *he,
19                       hpp_field_fn get_field, const char *fmt, int len,
20                       hpp_snprint_fn print_fn, bool fmt_percent)
21 {
22         int ret;
23         struct hists *hists = he->hists;
24         struct perf_evsel *evsel = hists_to_evsel(hists);
25         char *buf = hpp->buf;
26         size_t size = hpp->size;
27
28         if (fmt_percent) {
29                 double percent = 0.0;
30                 u64 total = hists__total_period(hists);
31
32                 if (total)
33                         percent = 100.0 * get_field(he) / total;
34
35                 ret = hpp__call_print_fn(hpp, print_fn, fmt, len, percent);
36         } else
37                 ret = hpp__call_print_fn(hpp, print_fn, fmt, len, get_field(he));
38
39         if (perf_evsel__is_group_event(evsel)) {
40                 int prev_idx, idx_delta;
41                 struct hist_entry *pair;
42                 int nr_members = evsel->nr_members;
43
44                 prev_idx = perf_evsel__group_idx(evsel);
45
46                 list_for_each_entry(pair, &he->pairs.head, pairs.node) {
47                         u64 period = get_field(pair);
48                         u64 total = hists__total_period(pair->hists);
49
50                         if (!total)
51                                 continue;
52
53                         evsel = hists_to_evsel(pair->hists);
54                         idx_delta = perf_evsel__group_idx(evsel) - prev_idx - 1;
55
56                         while (idx_delta--) {
57                                 /*
58                                  * zero-fill group members in the middle which
59                                  * have no sample
60                                  */
61                                 if (fmt_percent) {
62                                         ret += hpp__call_print_fn(hpp, print_fn,
63                                                                   fmt, len, 0.0);
64                                 } else {
65                                         ret += hpp__call_print_fn(hpp, print_fn,
66                                                                   fmt, len, 0ULL);
67                                 }
68                         }
69
70                         if (fmt_percent) {
71                                 ret += hpp__call_print_fn(hpp, print_fn, fmt, len,
72                                                           100.0 * period / total);
73                         } else {
74                                 ret += hpp__call_print_fn(hpp, print_fn, fmt,
75                                                           len, period);
76                         }
77
78                         prev_idx = perf_evsel__group_idx(evsel);
79                 }
80
81                 idx_delta = nr_members - prev_idx - 1;
82
83                 while (idx_delta--) {
84                         /*
85                          * zero-fill group members at last which have no sample
86                          */
87                         if (fmt_percent) {
88                                 ret += hpp__call_print_fn(hpp, print_fn,
89                                                           fmt, len, 0.0);
90                         } else {
91                                 ret += hpp__call_print_fn(hpp, print_fn,
92                                                           fmt, len, 0ULL);
93                         }
94                 }
95         }
96
97         /*
98          * Restore original buf and size as it's where caller expects
99          * the result will be saved.
100          */
101         hpp->buf = buf;
102         hpp->size = size;
103
104         return ret;
105 }
106
107 int hpp__fmt(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
108              struct hist_entry *he, hpp_field_fn get_field,
109              const char *fmtstr, hpp_snprint_fn print_fn, bool fmt_percent)
110 {
111         int len = fmt->user_len ?: fmt->len;
112
113         if (symbol_conf.field_sep) {
114                 return __hpp__fmt(hpp, he, get_field, fmtstr, 1,
115                                   print_fn, fmt_percent);
116         }
117
118         if (fmt_percent)
119                 len -= 2; /* 2 for a space and a % sign */
120         else
121                 len -= 1;
122
123         return  __hpp__fmt(hpp, he, get_field, fmtstr, len, print_fn, fmt_percent);
124 }
125
126 int hpp__fmt_acc(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
127                  struct hist_entry *he, hpp_field_fn get_field,
128                  const char *fmtstr, hpp_snprint_fn print_fn, bool fmt_percent)
129 {
130         if (!symbol_conf.cumulate_callchain) {
131                 int len = fmt->user_len ?: fmt->len;
132                 return snprintf(hpp->buf, hpp->size, " %*s", len - 1, "N/A");
133         }
134
135         return hpp__fmt(fmt, hpp, he, get_field, fmtstr, print_fn, fmt_percent);
136 }
137
138 static int field_cmp(u64 field_a, u64 field_b)
139 {
140         if (field_a > field_b)
141                 return 1;
142         if (field_a < field_b)
143                 return -1;
144         return 0;
145 }
146
147 static int __hpp__sort(struct hist_entry *a, struct hist_entry *b,
148                        hpp_field_fn get_field)
149 {
150         s64 ret;
151         int i, nr_members;
152         struct perf_evsel *evsel;
153         struct hist_entry *pair;
154         u64 *fields_a, *fields_b;
155
156         ret = field_cmp(get_field(a), get_field(b));
157         if (ret || !symbol_conf.event_group)
158                 return ret;
159
160         evsel = hists_to_evsel(a->hists);
161         if (!perf_evsel__is_group_event(evsel))
162                 return ret;
163
164         nr_members = evsel->nr_members;
165         fields_a = calloc(nr_members, sizeof(*fields_a));
166         fields_b = calloc(nr_members, sizeof(*fields_b));
167
168         if (!fields_a || !fields_b)
169                 goto out;
170
171         list_for_each_entry(pair, &a->pairs.head, pairs.node) {
172                 evsel = hists_to_evsel(pair->hists);
173                 fields_a[perf_evsel__group_idx(evsel)] = get_field(pair);
174         }
175
176         list_for_each_entry(pair, &b->pairs.head, pairs.node) {
177                 evsel = hists_to_evsel(pair->hists);
178                 fields_b[perf_evsel__group_idx(evsel)] = get_field(pair);
179         }
180
181         for (i = 1; i < nr_members; i++) {
182                 ret = field_cmp(fields_a[i], fields_b[i]);
183                 if (ret)
184                         break;
185         }
186
187 out:
188         free(fields_a);
189         free(fields_b);
190
191         return ret;
192 }
193
194 static int __hpp__sort_acc(struct hist_entry *a, struct hist_entry *b,
195                            hpp_field_fn get_field)
196 {
197         s64 ret = 0;
198
199         if (symbol_conf.cumulate_callchain) {
200                 /*
201                  * Put caller above callee when they have equal period.
202                  */
203                 ret = field_cmp(get_field(a), get_field(b));
204                 if (ret)
205                         return ret;
206
207                 if (a->thread != b->thread || !symbol_conf.use_callchain)
208                         return 0;
209
210                 ret = b->callchain->max_depth - a->callchain->max_depth;
211         }
212         return ret;
213 }
214
215 static int hpp__width_fn(struct perf_hpp_fmt *fmt,
216                          struct perf_hpp *hpp __maybe_unused,
217                          struct perf_evsel *evsel)
218 {
219         int len = fmt->user_len ?: fmt->len;
220
221         if (symbol_conf.event_group)
222                 len = max(len, evsel->nr_members * fmt->len);
223
224         if (len < (int)strlen(fmt->name))
225                 len = strlen(fmt->name);
226
227         return len;
228 }
229
230 static int hpp__header_fn(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
231                           struct perf_evsel *evsel)
232 {
233         int len = hpp__width_fn(fmt, hpp, evsel);
234         return scnprintf(hpp->buf, hpp->size, "%*s", len, fmt->name);
235 }
236
237 static int hpp_color_scnprintf(struct perf_hpp *hpp, const char *fmt, ...)
238 {
239         va_list args;
240         ssize_t ssize = hpp->size;
241         double percent;
242         int ret, len;
243
244         va_start(args, fmt);
245         len = va_arg(args, int);
246         percent = va_arg(args, double);
247         ret = percent_color_len_snprintf(hpp->buf, hpp->size, fmt, len, percent);
248         va_end(args);
249
250         return (ret >= ssize) ? (ssize - 1) : ret;
251 }
252
253 static int hpp_entry_scnprintf(struct perf_hpp *hpp, const char *fmt, ...)
254 {
255         va_list args;
256         ssize_t ssize = hpp->size;
257         int ret;
258
259         va_start(args, fmt);
260         ret = vsnprintf(hpp->buf, hpp->size, fmt, args);
261         va_end(args);
262
263         return (ret >= ssize) ? (ssize - 1) : ret;
264 }
265
266 #define __HPP_COLOR_PERCENT_FN(_type, _field)                                   \
267 static u64 he_get_##_field(struct hist_entry *he)                               \
268 {                                                                               \
269         return he->stat._field;                                                 \
270 }                                                                               \
271                                                                                 \
272 static int hpp__color_##_type(struct perf_hpp_fmt *fmt,                         \
273                               struct perf_hpp *hpp, struct hist_entry *he)      \
274 {                                                                               \
275         return hpp__fmt(fmt, hpp, he, he_get_##_field, " %*.2f%%",              \
276                         hpp_color_scnprintf, true);                             \
277 }
278
279 #define __HPP_ENTRY_PERCENT_FN(_type, _field)                                   \
280 static int hpp__entry_##_type(struct perf_hpp_fmt *fmt,                         \
281                               struct perf_hpp *hpp, struct hist_entry *he)      \
282 {                                                                               \
283         return hpp__fmt(fmt, hpp, he, he_get_##_field, " %*.2f%%",              \
284                         hpp_entry_scnprintf, true);                             \
285 }
286
287 #define __HPP_SORT_FN(_type, _field)                                            \
288 static int64_t hpp__sort_##_type(struct hist_entry *a, struct hist_entry *b)    \
289 {                                                                               \
290         return __hpp__sort(a, b, he_get_##_field);                              \
291 }
292
293 #define __HPP_COLOR_ACC_PERCENT_FN(_type, _field)                               \
294 static u64 he_get_acc_##_field(struct hist_entry *he)                           \
295 {                                                                               \
296         return he->stat_acc->_field;                                            \
297 }                                                                               \
298                                                                                 \
299 static int hpp__color_##_type(struct perf_hpp_fmt *fmt,                         \
300                               struct perf_hpp *hpp, struct hist_entry *he)      \
301 {                                                                               \
302         return hpp__fmt_acc(fmt, hpp, he, he_get_acc_##_field, " %*.2f%%",      \
303                             hpp_color_scnprintf, true);                         \
304 }
305
306 #define __HPP_ENTRY_ACC_PERCENT_FN(_type, _field)                               \
307 static int hpp__entry_##_type(struct perf_hpp_fmt *fmt,                         \
308                               struct perf_hpp *hpp, struct hist_entry *he)      \
309 {                                                                               \
310         return hpp__fmt_acc(fmt, hpp, he, he_get_acc_##_field, " %*.2f%%",      \
311                             hpp_entry_scnprintf, true);                         \
312 }
313
314 #define __HPP_SORT_ACC_FN(_type, _field)                                        \
315 static int64_t hpp__sort_##_type(struct hist_entry *a, struct hist_entry *b)    \
316 {                                                                               \
317         return __hpp__sort_acc(a, b, he_get_acc_##_field);                      \
318 }
319
320 #define __HPP_ENTRY_RAW_FN(_type, _field)                                       \
321 static u64 he_get_raw_##_field(struct hist_entry *he)                           \
322 {                                                                               \
323         return he->stat._field;                                                 \
324 }                                                                               \
325                                                                                 \
326 static int hpp__entry_##_type(struct perf_hpp_fmt *fmt,                         \
327                               struct perf_hpp *hpp, struct hist_entry *he)      \
328 {                                                                               \
329         return hpp__fmt(fmt, hpp, he, he_get_raw_##_field, " %*"PRIu64,         \
330                         hpp_entry_scnprintf, false);                            \
331 }
332
333 #define __HPP_SORT_RAW_FN(_type, _field)                                        \
334 static int64_t hpp__sort_##_type(struct hist_entry *a, struct hist_entry *b)    \
335 {                                                                               \
336         return __hpp__sort(a, b, he_get_raw_##_field);                          \
337 }
338
339
340 #define HPP_PERCENT_FNS(_type, _field)                                  \
341 __HPP_COLOR_PERCENT_FN(_type, _field)                                   \
342 __HPP_ENTRY_PERCENT_FN(_type, _field)                                   \
343 __HPP_SORT_FN(_type, _field)
344
345 #define HPP_PERCENT_ACC_FNS(_type, _field)                              \
346 __HPP_COLOR_ACC_PERCENT_FN(_type, _field)                               \
347 __HPP_ENTRY_ACC_PERCENT_FN(_type, _field)                               \
348 __HPP_SORT_ACC_FN(_type, _field)
349
350 #define HPP_RAW_FNS(_type, _field)                                      \
351 __HPP_ENTRY_RAW_FN(_type, _field)                                       \
352 __HPP_SORT_RAW_FN(_type, _field)
353
354 HPP_PERCENT_FNS(overhead, period)
355 HPP_PERCENT_FNS(overhead_sys, period_sys)
356 HPP_PERCENT_FNS(overhead_us, period_us)
357 HPP_PERCENT_FNS(overhead_guest_sys, period_guest_sys)
358 HPP_PERCENT_FNS(overhead_guest_us, period_guest_us)
359 HPP_PERCENT_ACC_FNS(overhead_acc, period)
360
361 HPP_RAW_FNS(samples, nr_events)
362 HPP_RAW_FNS(period, period)
363
364 static int64_t hpp__nop_cmp(struct hist_entry *a __maybe_unused,
365                             struct hist_entry *b __maybe_unused)
366 {
367         return 0;
368 }
369
370 #define HPP__COLOR_PRINT_FNS(_name, _fn)                \
371         {                                               \
372                 .name   = _name,                        \
373                 .header = hpp__header_fn,               \
374                 .width  = hpp__width_fn,                \
375                 .color  = hpp__color_ ## _fn,           \
376                 .entry  = hpp__entry_ ## _fn,           \
377                 .cmp    = hpp__nop_cmp,                 \
378                 .collapse = hpp__nop_cmp,               \
379                 .sort   = hpp__sort_ ## _fn,            \
380         }
381
382 #define HPP__COLOR_ACC_PRINT_FNS(_name, _fn)            \
383         {                                               \
384                 .name   = _name,                        \
385                 .header = hpp__header_fn,               \
386                 .width  = hpp__width_fn,                \
387                 .color  = hpp__color_ ## _fn,           \
388                 .entry  = hpp__entry_ ## _fn,           \
389                 .cmp    = hpp__nop_cmp,                 \
390                 .collapse = hpp__nop_cmp,               \
391                 .sort   = hpp__sort_ ## _fn,            \
392         }
393
394 #define HPP__PRINT_FNS(_name, _fn)                      \
395         {                                               \
396                 .name   = _name,                        \
397                 .header = hpp__header_fn,               \
398                 .width  = hpp__width_fn,                \
399                 .entry  = hpp__entry_ ## _fn,           \
400                 .cmp    = hpp__nop_cmp,                 \
401                 .collapse = hpp__nop_cmp,               \
402                 .sort   = hpp__sort_ ## _fn,            \
403         }
404
405 struct perf_hpp_fmt perf_hpp__format[] = {
406         HPP__COLOR_PRINT_FNS("Overhead", overhead),
407         HPP__COLOR_PRINT_FNS("sys", overhead_sys),
408         HPP__COLOR_PRINT_FNS("usr", overhead_us),
409         HPP__COLOR_PRINT_FNS("guest sys", overhead_guest_sys),
410         HPP__COLOR_PRINT_FNS("guest usr", overhead_guest_us),
411         HPP__COLOR_ACC_PRINT_FNS("Children", overhead_acc),
412         HPP__PRINT_FNS("Samples", samples),
413         HPP__PRINT_FNS("Period", period)
414 };
415
416 LIST_HEAD(perf_hpp__list);
417 LIST_HEAD(perf_hpp__sort_list);
418
419
420 #undef HPP__COLOR_PRINT_FNS
421 #undef HPP__COLOR_ACC_PRINT_FNS
422 #undef HPP__PRINT_FNS
423
424 #undef HPP_PERCENT_FNS
425 #undef HPP_PERCENT_ACC_FNS
426 #undef HPP_RAW_FNS
427
428 #undef __HPP_HEADER_FN
429 #undef __HPP_WIDTH_FN
430 #undef __HPP_COLOR_PERCENT_FN
431 #undef __HPP_ENTRY_PERCENT_FN
432 #undef __HPP_COLOR_ACC_PERCENT_FN
433 #undef __HPP_ENTRY_ACC_PERCENT_FN
434 #undef __HPP_ENTRY_RAW_FN
435 #undef __HPP_SORT_FN
436 #undef __HPP_SORT_ACC_FN
437 #undef __HPP_SORT_RAW_FN
438
439
440 void perf_hpp__init(void)
441 {
442         struct list_head *list;
443         int i;
444
445         for (i = 0; i < PERF_HPP__MAX_INDEX; i++) {
446                 struct perf_hpp_fmt *fmt = &perf_hpp__format[i];
447
448                 INIT_LIST_HEAD(&fmt->list);
449
450                 /* sort_list may be linked by setup_sorting() */
451                 if (fmt->sort_list.next == NULL)
452                         INIT_LIST_HEAD(&fmt->sort_list);
453         }
454
455         /*
456          * If user specified field order, no need to setup default fields.
457          */
458         if (is_strict_order(field_order))
459                 return;
460
461         if (symbol_conf.cumulate_callchain) {
462                 perf_hpp__column_enable(PERF_HPP__OVERHEAD_ACC);
463                 perf_hpp__format[PERF_HPP__OVERHEAD].name = "Self";
464         }
465
466         perf_hpp__column_enable(PERF_HPP__OVERHEAD);
467
468         if (symbol_conf.show_cpu_utilization) {
469                 perf_hpp__column_enable(PERF_HPP__OVERHEAD_SYS);
470                 perf_hpp__column_enable(PERF_HPP__OVERHEAD_US);
471
472                 if (perf_guest) {
473                         perf_hpp__column_enable(PERF_HPP__OVERHEAD_GUEST_SYS);
474                         perf_hpp__column_enable(PERF_HPP__OVERHEAD_GUEST_US);
475                 }
476         }
477
478         if (symbol_conf.show_nr_samples)
479                 perf_hpp__column_enable(PERF_HPP__SAMPLES);
480
481         if (symbol_conf.show_total_period)
482                 perf_hpp__column_enable(PERF_HPP__PERIOD);
483
484         /* prepend overhead field for backward compatiblity.  */
485         list = &perf_hpp__format[PERF_HPP__OVERHEAD].sort_list;
486         if (list_empty(list))
487                 list_add(list, &perf_hpp__sort_list);
488
489         if (symbol_conf.cumulate_callchain) {
490                 list = &perf_hpp__format[PERF_HPP__OVERHEAD_ACC].sort_list;
491                 if (list_empty(list))
492                         list_add(list, &perf_hpp__sort_list);
493         }
494 }
495
496 void perf_hpp__column_register(struct perf_hpp_fmt *format)
497 {
498         list_add_tail(&format->list, &perf_hpp__list);
499 }
500
501 void perf_hpp__column_unregister(struct perf_hpp_fmt *format)
502 {
503         list_del(&format->list);
504 }
505
506 void perf_hpp__register_sort_field(struct perf_hpp_fmt *format)
507 {
508         list_add_tail(&format->sort_list, &perf_hpp__sort_list);
509 }
510
511 void perf_hpp__column_enable(unsigned col)
512 {
513         BUG_ON(col >= PERF_HPP__MAX_INDEX);
514         perf_hpp__column_register(&perf_hpp__format[col]);
515 }
516
517 void perf_hpp__column_disable(unsigned col)
518 {
519         BUG_ON(col >= PERF_HPP__MAX_INDEX);
520         perf_hpp__column_unregister(&perf_hpp__format[col]);
521 }
522
523 void perf_hpp__cancel_cumulate(void)
524 {
525         if (is_strict_order(field_order))
526                 return;
527
528         perf_hpp__column_disable(PERF_HPP__OVERHEAD_ACC);
529         perf_hpp__format[PERF_HPP__OVERHEAD].name = "Overhead";
530 }
531
532 void perf_hpp__setup_output_field(void)
533 {
534         struct perf_hpp_fmt *fmt;
535
536         /* append sort keys to output field */
537         perf_hpp__for_each_sort_list(fmt) {
538                 if (!list_empty(&fmt->list))
539                         continue;
540
541                 /*
542                  * sort entry fields are dynamically created,
543                  * so they can share a same sort key even though
544                  * the list is empty.
545                  */
546                 if (perf_hpp__is_sort_entry(fmt)) {
547                         struct perf_hpp_fmt *pos;
548
549                         perf_hpp__for_each_format(pos) {
550                                 if (perf_hpp__same_sort_entry(pos, fmt))
551                                         goto next;
552                         }
553                 }
554
555                 perf_hpp__column_register(fmt);
556 next:
557                 continue;
558         }
559 }
560
561 void perf_hpp__append_sort_keys(void)
562 {
563         struct perf_hpp_fmt *fmt;
564
565         /* append output fields to sort keys */
566         perf_hpp__for_each_format(fmt) {
567                 if (!list_empty(&fmt->sort_list))
568                         continue;
569
570                 /*
571                  * sort entry fields are dynamically created,
572                  * so they can share a same sort key even though
573                  * the list is empty.
574                  */
575                 if (perf_hpp__is_sort_entry(fmt)) {
576                         struct perf_hpp_fmt *pos;
577
578                         perf_hpp__for_each_sort_list(pos) {
579                                 if (perf_hpp__same_sort_entry(pos, fmt))
580                                         goto next;
581                         }
582                 }
583
584                 perf_hpp__register_sort_field(fmt);
585 next:
586                 continue;
587         }
588 }
589
590 void perf_hpp__reset_output_field(void)
591 {
592         struct perf_hpp_fmt *fmt, *tmp;
593
594         /* reset output fields */
595         perf_hpp__for_each_format_safe(fmt, tmp) {
596                 list_del_init(&fmt->list);
597                 list_del_init(&fmt->sort_list);
598         }
599
600         /* reset sort keys */
601         perf_hpp__for_each_sort_list_safe(fmt, tmp) {
602                 list_del_init(&fmt->list);
603                 list_del_init(&fmt->sort_list);
604         }
605 }
606
607 /*
608  * See hists__fprintf to match the column widths
609  */
610 unsigned int hists__sort_list_width(struct hists *hists)
611 {
612         struct perf_hpp_fmt *fmt;
613         int ret = 0;
614         bool first = true;
615         struct perf_hpp dummy_hpp;
616
617         perf_hpp__for_each_format(fmt) {
618                 if (perf_hpp__should_skip(fmt))
619                         continue;
620
621                 if (first)
622                         first = false;
623                 else
624                         ret += 2;
625
626                 ret += fmt->width(fmt, &dummy_hpp, hists_to_evsel(hists));
627         }
628
629         if (verbose && sort__has_sym) /* Addr + origin */
630                 ret += 3 + BITS_PER_LONG / 4;
631
632         return ret;
633 }
634
635 void perf_hpp__reset_width(struct perf_hpp_fmt *fmt, struct hists *hists)
636 {
637         int idx;
638
639         if (perf_hpp__is_sort_entry(fmt))
640                 return perf_hpp__reset_sort_width(fmt, hists);
641
642         for (idx = 0; idx < PERF_HPP__MAX_INDEX; idx++) {
643                 if (fmt == &perf_hpp__format[idx])
644                         break;
645         }
646
647         if (idx == PERF_HPP__MAX_INDEX)
648                 return;
649
650         switch (idx) {
651         case PERF_HPP__OVERHEAD:
652         case PERF_HPP__OVERHEAD_SYS:
653         case PERF_HPP__OVERHEAD_US:
654         case PERF_HPP__OVERHEAD_ACC:
655                 fmt->len = 8;
656                 break;
657
658         case PERF_HPP__OVERHEAD_GUEST_SYS:
659         case PERF_HPP__OVERHEAD_GUEST_US:
660                 fmt->len = 9;
661                 break;
662
663         case PERF_HPP__SAMPLES:
664         case PERF_HPP__PERIOD:
665                 fmt->len = 12;
666                 break;
667
668         default:
669                 break;
670         }
671 }
672
673 void perf_hpp__set_user_width(const char *width_list_str)
674 {
675         struct perf_hpp_fmt *fmt;
676         const char *ptr = width_list_str;
677
678         perf_hpp__for_each_format(fmt) {
679                 char *p;
680
681                 int len = strtol(ptr, &p, 10);
682                 fmt->user_len = len;
683
684                 if (*p == ',')
685                         ptr = p + 1;
686                 else
687                         break;
688         }
689 }