mfd: cros_ec: Delay for 50ms when we see EC_CMD_REBOOT_EC
authorDoug Anderson <dianders@chromium.org>
Thu, 18 Sep 2014 15:18:54 +0000 (17:18 +0200)
committerLee Jones <lee.jones@linaro.org>
Mon, 6 Oct 2014 20:28:48 +0000 (21:28 +0100)
commit659e142be09482cfd8b9017f616afebc7cf48fa3
treec26148959a3cbe749c7084dcf1579573ccb047d9
parent48b490d23ef5aaf65e16e194e0fd2578a9b6497f
mfd: cros_ec: Delay for 50ms when we see EC_CMD_REBOOT_EC

If someone sends a EC_CMD_REBOOT_EC to the EC, the EC will likely be
unresponsive for quite a while.  Add a delay to the end of the command
to prevent random failures of future commands.

NOTES:
* This could be optimized a bit by simply delaying the next command
  sent, but EC_CMD_REBOOT_EC is such a rare command that the extra
  complexity doesn't seem worth it.
* This is a bit of an "ugly hack" since the SPI driver is effectively
  snooping on the communication and making a lot of assumptions.  It
  would be nice to architect in some better solution long term.
* This same logic probably needs to be applied to the i2c driver.

Signed-off-by: Doug Anderson <dianders@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/cros_ec_spi.c