usb: misc: yurex: don't print on ENOMEM
authorWolfram Sang <wsa-dev@sang-engineering.com>
Thu, 25 Aug 2016 17:39:25 +0000 (19:39 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 Aug 2016 17:17:38 +0000 (19:17 +0200)
All kmalloc-based functions print enough information on failures.

Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/yurex.c

index bb606bd..54e53ac 100644 (file)
@@ -200,10 +200,8 @@ static int yurex_probe(struct usb_interface *interface, const struct usb_device_
 
        /* allocate memory for our device state and initialize it */
        dev = kzalloc(sizeof(*dev), GFP_KERNEL);
 
        /* allocate memory for our device state and initialize it */
        dev = kzalloc(sizeof(*dev), GFP_KERNEL);
-       if (!dev) {
-               dev_err(&interface->dev, "Out of memory\n");
+       if (!dev)
                goto error;
                goto error;
-       }
        kref_init(&dev->kref);
        mutex_init(&dev->io_mutex);
        spin_lock_init(&dev->lock);
        kref_init(&dev->kref);
        mutex_init(&dev->io_mutex);
        spin_lock_init(&dev->lock);
@@ -236,10 +234,8 @@ static int yurex_probe(struct usb_interface *interface, const struct usb_device_
 
        /* allocate buffer for control req */
        dev->cntl_req = kmalloc(YUREX_BUF_SIZE, GFP_KERNEL);
 
        /* allocate buffer for control req */
        dev->cntl_req = kmalloc(YUREX_BUF_SIZE, GFP_KERNEL);
-       if (!dev->cntl_req) {
-               dev_err(&interface->dev, "Could not allocate cntl_req\n");
+       if (!dev->cntl_req)
                goto error;
                goto error;
-       }
 
        /* allocate buffer for control msg */
        dev->cntl_buffer = usb_alloc_coherent(dev->udev, YUREX_BUF_SIZE,
 
        /* allocate buffer for control msg */
        dev->cntl_buffer = usb_alloc_coherent(dev->udev, YUREX_BUF_SIZE,