OMAPFB: fix releasing overlays
authorTomi Valkeinen <tomi.valkeinen@ti.com>
Thu, 16 Oct 2014 09:19:37 +0000 (12:19 +0300)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Wed, 22 Oct 2014 08:07:08 +0000 (11:07 +0300)
omapfb disables all the overlays when freeing resources, but it should
also remove those overlays from overlay managers.

Not doing so causes a crash if omapfb is unbound and bound, or omapfb
module is removed and loaded, while keeping omapdss around.

Fix this by calling unset_manager() for all overlays.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/fbdev/omap2/omapfb/omapfb-main.c

index a04096a..ce8a705 100644 (file)
@@ -1837,6 +1837,9 @@ static void omapfb_free_resources(struct omapfb2_device *fbdev)
                struct omap_overlay *ovl = fbdev->overlays[i];
 
                ovl->disable(ovl);
+
+               if (ovl->manager)
+                       ovl->unset_manager(ovl);
        }
 
        for (i = 0; i < fbdev->num_fbs; i++)