intel_th: Use real device index in the node names
authorAlexander Shishkin <alexander.shishkin@linux.intel.com>
Mon, 15 Feb 2016 17:12:00 +0000 (19:12 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 20 Feb 2016 22:09:14 +0000 (14:09 -0800)
Most of the intel_th core supports multiple co-existing TH devices,
except for output device nodes, where intel_th device id is hardcoded
to be zero.

Fix this by fetching the actual intel_th device id from the parent
device's drvdata.

Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwtracing/intel_th/core.c

index 6df3cd9..4272f2c 100644 (file)
@@ -124,17 +124,34 @@ static struct device_type intel_th_source_device_type = {
        .release        = intel_th_device_release,
 };
 
+static struct intel_th *to_intel_th(struct intel_th_device *thdev)
+{
+       /*
+        * subdevice tree is flat: if this one is not a switch, its
+        * parent must be
+        */
+       if (thdev->type != INTEL_TH_SWITCH)
+               thdev = to_intel_th_hub(thdev);
+
+       if (WARN_ON_ONCE(!thdev || thdev->type != INTEL_TH_SWITCH))
+               return NULL;
+
+       return dev_get_drvdata(thdev->dev.parent);
+}
+
 static char *intel_th_output_devnode(struct device *dev, umode_t *mode,
                                     kuid_t *uid, kgid_t *gid)
 {
        struct intel_th_device *thdev = to_intel_th_device(dev);
+       struct intel_th *th = to_intel_th(thdev);
        char *node;
 
        if (thdev->id >= 0)
-               node = kasprintf(GFP_KERNEL, "intel_th%d/%s%d", 0, thdev->name,
-                                thdev->id);
+               node = kasprintf(GFP_KERNEL, "intel_th%d/%s%d", th->id,
+                                thdev->name, thdev->id);
        else
-               node = kasprintf(GFP_KERNEL, "intel_th%d/%s", 0, thdev->name);
+               node = kasprintf(GFP_KERNEL, "intel_th%d/%s", th->id,
+                                thdev->name);
 
        return node;
 }