net_sched: check NULL on error path in route4_change()
authorWANG Cong <xiyou.wangcong@gmail.com>
Sun, 18 Sep 2016 22:52:20 +0000 (15:52 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 23 Sep 2016 10:51:49 +0000 (06:51 -0400)
On error path in route4_change(), 'f' could be NULL,
so we should check NULL before calling tcf_exts_destroy().

Fixes: b9a24bb76bf6 ("net_sched: properly handle failure case of tcf_exts_init()")
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/cls_route.c

index a4ce39b..455fc8f 100644 (file)
@@ -559,7 +559,8 @@ static int route4_change(struct net *net, struct sk_buff *in_skb,
        return 0;
 
 errout:
-       tcf_exts_destroy(&f->exts);
+       if (f)
+               tcf_exts_destroy(&f->exts);
        kfree(f);
        return err;
 }