tools lib traceevent: Fix a risk for doing free on uninitialized pointer
authorRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Tue, 24 Jun 2014 11:09:10 +0000 (13:09 +0200)
committerJiri Olsa <jolsa@kernel.org>
Fri, 27 Jun 2014 09:14:47 +0000 (11:14 +0200)
Fix a risk of doing free on an uninitialized pointer.

This was found using a static code analysis program called cppcheck.

Acked-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Link: http://lkml.kernel.org/r/1403608150-13037-1-git-send-email-rickard_strandqvist@spectrumdigital.se
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
tools/lib/traceevent/event-parse.c

index 93825a1..cf3a44b 100644 (file)
@@ -2395,7 +2395,7 @@ process_flags(struct event_format *event, struct print_arg *arg, char **tok)
 {
        struct print_arg *field;
        enum event_type type;
-       char *token;
+       char *token = NULL;
 
        memset(arg, 0, sizeof(*arg));
        arg->type = PRINT_FLAGS;
@@ -2448,7 +2448,7 @@ process_symbols(struct event_format *event, struct print_arg *arg, char **tok)
 {
        struct print_arg *field;
        enum event_type type;
-       char *token;
+       char *token = NULL;
 
        memset(arg, 0, sizeof(*arg));
        arg->type = PRINT_SYMBOL;
@@ -2487,7 +2487,7 @@ process_hex(struct event_format *event, struct print_arg *arg, char **tok)
 {
        struct print_arg *field;
        enum event_type type;
-       char *token;
+       char *token = NULL;
 
        memset(arg, 0, sizeof(*arg));
        arg->type = PRINT_HEX;