spi: pxa2xx-pci: Remove unused code
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 4 Jul 2016 09:44:26 +0000 (12:44 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 4 Jul 2016 14:13:42 +0000 (16:13 +0200)
pcim_iomap_table() can't fail when called after pcim_iomap_regions(). Moreover,
we already dereference returned value and kernel will crash if it is not
correct.

Remove obvious leftover of commit 0202775bc3a2 ("spi/pxa2xx-pci: switch to use
pcim_* interfaces").

Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-pxa2xx-pci.c

index b025eaf..4e3c5a7 100644 (file)
@@ -202,10 +202,6 @@ static int pxa2xx_spi_pci_probe(struct pci_dev *dev,
        ssp = &spi_pdata.ssp;
        ssp->phys_base = pci_resource_start(dev, 0);
        ssp->mmio_base = pcim_iomap_table(dev)[0];
-       if (!ssp->mmio_base) {
-               dev_err(&dev->dev, "failed to ioremap() registers\n");
-               return -EIO;
-       }
        ssp->irq = dev->irq;
        ssp->port_id = (c->port_id >= 0) ? c->port_id : dev->devfn;
        ssp->type = c->type;