ATM-nicstar: Refactor a kmalloc() call in ns_init_card()

* The script "checkpatch.pl" can point out that assignments should usually
  not be performed within condition checks.
  Thus move an assignment for a local variable to a separate statement
  in this function.

* Replace the specification of a data structure by a pointer dereference
  as the parameter for the operator "sizeof" to make the corresponding size
  determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/atm/nicstar.c b/drivers/atm/nicstar.c
index ef977bf..04f5781 100644 (file)
--- a/drivers/atm/nicstar.c
+++ b/drivers/atm/nicstar.c
@@ -370,7 +370,8 @@ static int ns_init_card(int i, struct pci_dev *pcidev)
                return error;
         }
 
-       if ((card = kmalloc(sizeof(ns_dev), GFP_KERNEL)) == NULL) {
+       card = kmalloc(sizeof(*card), GFP_KERNEL);
+       if (!card) {
                printk
                    ("nicstar%d: can't allocate memory for device structure.\n",
                     i);