clk: stm32f4: fix error handling
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 3 Jul 2016 06:06:43 +0000 (08:06 +0200)
committerMichael Turquette <mturquette@baylibre.com>
Thu, 7 Jul 2016 00:55:31 +0000 (17:55 -0700)
This is likely that checking 'clks[idx]' instead of 'clks[n]' is
expected here.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Michael Turquette <mturquette@baylibre.com>
Link: lkml.kernel.org/r/1467526003-13318-1-git-send-email-christophe.jaillet@wanadoo.fr

drivers/clk/clk-stm32f4.c

index b6ca33f..02d6810 100644 (file)
@@ -364,7 +364,7 @@ static void __init stm32f4_rcc_init(struct device_node *np)
                    NULL, gd->name, gd->parent_name, gd->flags,
                    base + gd->offset, gd->bit_idx, 0, &stm32f4_clk_lock);
 
                    NULL, gd->name, gd->parent_name, gd->flags,
                    base + gd->offset, gd->bit_idx, 0, &stm32f4_clk_lock);
 
-               if (IS_ERR(clks[n])) {
+               if (IS_ERR(clks[idx])) {
                        pr_err("%s: Unable to register leaf clock %s\n",
                               np->full_name, gd->name);
                        goto fail;
                        pr_err("%s: Unable to register leaf clock %s\n",
                               np->full_name, gd->name);
                        goto fail;