usb: chipidea: udc: Use dma_pool_zalloc()
authorFabio Estevam <fabio.estevam@nxp.com>
Thu, 8 Sep 2016 12:34:30 +0000 (09:34 -0300)
committerPeter Chen <peter.chen@nxp.com>
Wed, 14 Sep 2016 02:58:13 +0000 (10:58 +0800)
We can make the code simpler by using dma_pool_zalloc() instead
of calling dma_pool_alloc() and then a memset().

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
drivers/usb/chipidea/udc.c

index c1eea62..a0b208d 100644 (file)
@@ -1677,12 +1677,10 @@ static int init_eps(struct ci_hdrc *ci)
                        usb_ep_set_maxpacket_limit(&hwep->ep, (unsigned short)~0);
 
                        INIT_LIST_HEAD(&hwep->qh.queue);
-                       hwep->qh.ptr = dma_pool_alloc(ci->qh_pool, GFP_KERNEL,
-                                                    &hwep->qh.dma);
+                       hwep->qh.ptr = dma_pool_zalloc(ci->qh_pool, GFP_KERNEL,
+                                                      &hwep->qh.dma);
                        if (hwep->qh.ptr == NULL)
                                retval = -ENOMEM;
-                       else
-                               memset(hwep->qh.ptr, 0, sizeof(*hwep->qh.ptr));
 
                        /*
                         * set up shorthands for ep0 out and in endpoints,