staging: lustre: Cleaning up unnecessary use of memset in conjunction with strncpy
authorRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Sun, 14 Sep 2014 16:03:16 +0000 (18:03 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 14 Sep 2014 17:05:11 +0000 (10:05 -0700)
Using memset before strncpy just to ensure a trailing null
character is an unnecessary double writing of a string

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/libcfs/debug.c

index 48c5d55..ba43b30 100644 (file)
@@ -401,9 +401,9 @@ int libcfs_debug_init(unsigned long bufsize)
        }
 
        if (libcfs_debug_file_path != NULL) {
-               memset(libcfs_debug_file_path_arr, 0, PATH_MAX);
                strncpy(libcfs_debug_file_path_arr,
                        libcfs_debug_file_path, PATH_MAX-1);
+               libcfs_debug_file_path_arr[PATH_MAX - 1] = '\0';
        }
 
        /* If libcfs_debug_mb is set to an invalid value or uninitialized