perf tools: Get rid of exit_browser() from usage_with_options()
authorNamhyung Kim <namhyung@kernel.org>
Thu, 10 Dec 2015 03:00:59 +0000 (12:00 +0900)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 10 Dec 2015 18:47:52 +0000 (15:47 -0300)
Since all of its users call before setup_browser(), there's no need to
call exit_browser() inside of the function.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1449716459-23004-8-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/parse-options.c

index d09aff9..de3290b 100644 (file)
@@ -766,7 +766,6 @@ int usage_with_options_internal(const char * const *usagestr,
 void usage_with_options(const char * const *usagestr,
                        const struct option *opts)
 {
-       exit_browser(false);
        usage_with_options_internal(usagestr, opts, 0, NULL);
        exit(129);
 }
@@ -776,8 +775,6 @@ void usage_with_options_msg(const char * const *usagestr,
 {
        va_list ap;
 
-       exit_browser(false);
-
        va_start(ap, fmt);
        strbuf_addv(&error_buf, fmt, ap);
        va_end(ap);