autofs: don't fail to free_dev_ioctl(param)
authorTomohiro Kusumi <kusumi.tomohiro@gmail.com>
Tue, 11 Oct 2016 20:52:48 +0000 (13:52 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 11 Oct 2016 22:06:31 +0000 (15:06 -0700)
Returning -ENOTTY here fails to free dynamically allocated param.

Link: http://lkml.kernel.org/r/20160812024815.12352.69153.stgit@pluto.themaw.net
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Signed-off-by: Ian Kent <ikent@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/autofs4/dev-ioctl.c

index c7fcc74..d47b35a 100644 (file)
@@ -662,7 +662,8 @@ static int _autofs_dev_ioctl(unsigned int command,
        fn = lookup_dev_ioctl(cmd);
        if (!fn) {
                pr_warn("unknown command 0x%08x\n", command);
-               return -ENOTTY;
+               err = -ENOTTY;
+               goto out;
        }
 
        fp = NULL;