ASoC: mxs-saif: check BUSY bit in hw_params() only if not mclk_in_use
authorMans Rullgard <mans@mansr.com>
Wed, 3 Feb 2016 13:18:20 +0000 (13:18 +0000)
committerMark Brown <broonie@kernel.org>
Fri, 5 Feb 2016 13:22:49 +0000 (13:22 +0000)
If something else, typically a codec, has enabled mclk, the BUSY
bit may be set when hw_params() is called without this being an
error.  This check thus causes intermittent failures to configure
the sound device when used in such a manner.  Fix this by making
the test conditional on !saif->mclk_in_use.

Signed-off-by: Mans Rullgard <mans@mansr.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/mxs/mxs-saif.c

index c866ade..cd04eb7 100644 (file)
@@ -408,7 +408,7 @@ static int mxs_saif_hw_params(struct snd_pcm_substream *substream,
        }
 
        stat = __raw_readl(saif->base + SAIF_STAT);
-       if (stat & BM_SAIF_STAT_BUSY) {
+       if (!saif->mclk_in_use && (stat & BM_SAIF_STAT_BUSY)) {
                dev_err(cpu_dai->dev, "error: busy\n");
                return -EBUSY;
        }