UBI: block: Make ubiblock_resize return something
authorEzequiel Garcia <ezequiel.garcia@free-electrons.com>
Mon, 5 May 2014 10:11:52 +0000 (07:11 -0300)
committerArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
Mon, 28 Jul 2014 15:52:06 +0000 (18:52 +0300)
Currently, ubiblock_resize() can fail if the device is not found
in the list. This commit changes the return type, so the function can
return something meaningful on error paths.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
drivers/mtd/ubi/block.c

index 8457df7..52cefae 100644 (file)
@@ -498,7 +498,7 @@ int ubiblock_remove(struct ubi_volume_info *vi)
        return 0;
 }
 
-static void ubiblock_resize(struct ubi_volume_info *vi)
+static int ubiblock_resize(struct ubi_volume_info *vi)
 {
        struct ubiblock *dev;
        int disk_capacity;
@@ -512,7 +512,7 @@ static void ubiblock_resize(struct ubi_volume_info *vi)
        dev = find_dev_nolock(vi->ubi_num, vi->vol_id);
        if (!dev) {
                mutex_unlock(&devices_mutex);
-               return;
+               return -ENODEV;
        }
 
        mutex_lock(&dev->dev_mutex);
@@ -521,6 +521,7 @@ static void ubiblock_resize(struct ubi_volume_info *vi)
        ubi_msg("%s resized to %d LEBs", dev->gd->disk_name, vi->size);
        mutex_unlock(&dev->dev_mutex);
        mutex_unlock(&devices_mutex);
+       return 0;
 }
 
 static int ubiblock_notify(struct notifier_block *nb,