iwlwifi: mvm: reset mvm->scan_type when firmware is started
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Sun, 3 Jan 2016 20:23:40 +0000 (22:23 +0200)
committerEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Thu, 7 Jan 2016 17:01:25 +0000 (19:01 +0200)
If we don't reset the scan type when the firmware is
started, we will think the firmware is still configured
after the interface has been brought down. When we will
bring it up again, we will not configure the scan type
in firmware and it will crash with the following assert:

0x0000100A | ADVANCED_SYSASSERT

Fixes: 355346ba3050 ("iwlwifi: mvm: configure scheduled scan according to traffic conditions")
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/fw.c
drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c

index e6e8088..4ed5180 100644 (file)
@@ -943,6 +943,7 @@ int iwl_mvm_up(struct iwl_mvm *mvm)
        }
 
        if (fw_has_capa(&mvm->fw->ucode_capa, IWL_UCODE_TLV_CAPA_UMAC_SCAN)) {
+               mvm->scan_type = IWL_SCAN_TYPE_NOT_SET;
                ret = iwl_mvm_config_scan(mvm);
                if (ret)
                        goto error;
index 296b9c5..2d65040 100644 (file)
@@ -1002,7 +1002,6 @@ static void iwl_mvm_restart_cleanup(struct iwl_mvm *mvm)
        mvm->vif_count = 0;
        mvm->rx_ba_sessions = 0;
        mvm->fw_dbg_conf = FW_DBG_INVALID;
-       mvm->scan_type = IWL_SCAN_TYPE_NOT_SET;
 
        /* keep statistics ticking */
        iwl_mvm_accu_radio_stats(mvm);