arch: tile: kernel: unaligned.c: Cleaning up uninitialized variables

There is a risk that the variable will be used without being initialized.

This was largely found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Chris Metcalf <cmetcalf@tilera.com> [minor cleanups]

diff --git a/arch/tile/kernel/unaligned.c b/arch/tile/kernel/unaligned.c
index b030b4e..c02ea2a 100644 (file)
--- a/arch/tile/kernel/unaligned.c
+++ b/arch/tile/kernel/unaligned.c
@@ -182,18 +182,7 @@ static void find_regs(tilegx_bundle_bits bundle, uint64_t *rd, uint64_t *ra,
        int i;
        uint64_t reg;
        uint64_t reg_map = 0, alias_reg_map = 0, map;
-       bool alias;
-
-       *ra = -1;
-       *rb = -1;
-
-       if (rd)
-               *rd = -1;
-
-       *clob1 = -1;
-       *clob2 = -1;
-       *clob3 = -1;
-       alias = false;
+       bool alias = false;
 
        /*
         * Parse fault bundle, find potential used registers and mark
@@ -569,7 +558,7 @@ void jit_bundle_gen(struct pt_regs *regs, tilegx_bundle_bits bundle,
        tilegx_bundle_bits bundle_2 = 0;
        /* If bundle_2_enable = false, bundle_2 is fnop/nop operation. */
        bool     bundle_2_enable = true;
-       uint64_t ra, rb, rd = -1, clob1, clob2, clob3;
+       uint64_t ra = -1, rb = -1, rd = -1, clob1 = -1, clob2 = -1, clob3 = -1;
        /*
         * Indicate if the unalign access
         * instruction's registers hit with