mac80211: cleanup offchannel_ps_enable argument
authorRajkumar Manoharan <rmanohar@qca.qualcomm.com>
Mon, 18 Jun 2012 13:33:52 +0000 (19:03 +0530)
committerJohannes Berg <johannes.berg@intel.com>
Wed, 20 Jun 2012 08:53:34 +0000 (10:53 +0200)
The 'tell_ap' argument is always true. So that remove it
and simplify the function.

Signed-off-by: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/offchannel.c

index fcb01ee..febce7f 100644 (file)
@@ -25,8 +25,7 @@
  * because we *may* be doing work on-operating channel, and want our
  * hardware unconditionally awake, but still let the AP send us normal frames.
  */
-static void ieee80211_offchannel_ps_enable(struct ieee80211_sub_if_data *sdata,
-                                          bool tell_ap)
+static void ieee80211_offchannel_ps_enable(struct ieee80211_sub_if_data *sdata)
 {
        struct ieee80211_local *local = sdata->local;
        struct ieee80211_if_managed *ifmgd = &sdata->u.mgd;
@@ -47,8 +46,8 @@ static void ieee80211_offchannel_ps_enable(struct ieee80211_sub_if_data *sdata,
                ieee80211_hw_config(local, IEEE80211_CONF_CHANGE_PS);
        }
 
-       if (tell_ap && (!local->offchannel_ps_enabled ||
-                       !(local->hw.flags & IEEE80211_HW_PS_NULLFUNC_STACK)))
+       if (!local->offchannel_ps_enabled ||
+           !(local->hw.flags & IEEE80211_HW_PS_NULLFUNC_STACK))
                /*
                 * If power save was enabled, no need to send a nullfunc
                 * frame because AP knows that we are sleeping. But if the
@@ -133,7 +132,7 @@ void ieee80211_offchannel_stop_vifs(struct ieee80211_local *local,
                        if (offchannel_ps_enable &&
                            (sdata->vif.type == NL80211_IFTYPE_STATION) &&
                            sdata->u.mgd.associated)
-                               ieee80211_offchannel_ps_enable(sdata, true);
+                               ieee80211_offchannel_ps_enable(sdata);
                }
        }
        mutex_unlock(&local->iflist_mtx);