HID: input: ignore the battery in OKLICK Laser BTmouse
authorAlexander E. Patrakov <patrakov@gmail.com>
Mon, 14 Dec 2015 12:42:26 +0000 (17:42 +0500)
committerJiri Kosina <jkosina@suse.cz>
Thu, 17 Dec 2015 23:09:27 +0000 (00:09 +0100)
This mouse, when asked about the battery, ceases to report movements and
clicks. So just don't ask.

Signed-off-by: Alexander E. Patrakov <patrakov@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-input.c

index 2ba6bf6..0869fae 100644 (file)
@@ -303,6 +303,7 @@ static enum power_supply_property hidinput_battery_props[] = {
 
 #define HID_BATTERY_QUIRK_PERCENT      (1 << 0) /* always reports percent */
 #define HID_BATTERY_QUIRK_FEATURE      (1 << 1) /* ask for feature report */
+#define HID_BATTERY_QUIRK_IGNORE       (1 << 2) /* completely ignore the battery */
 
 static const struct hid_device_id hid_battery_quirks[] = {
        { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
@@ -320,6 +321,9 @@ static const struct hid_device_id hid_battery_quirks[] = {
        { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
                USB_DEVICE_ID_APPLE_ALU_WIRELESS_ANSI),
          HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
+       { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_ELECOM,
+               USB_DEVICE_ID_ELECOM_BM084),
+         HID_BATTERY_QUIRK_IGNORE },
        {}
 };
 
@@ -408,6 +412,14 @@ static bool hidinput_setup_battery(struct hid_device *dev, unsigned report_type,
        if (dev->battery != NULL)
                goto out;       /* already initialized? */
 
+       quirks = find_battery_quirk(dev);
+
+       hid_dbg(dev, "device %x:%x:%x %d quirks %d\n",
+               dev->bus, dev->vendor, dev->product, dev->version, quirks);
+
+       if (quirks & HID_BATTERY_QUIRK_IGNORE)
+               goto out;
+
        psy_desc = kzalloc(sizeof(*psy_desc), GFP_KERNEL);
        if (psy_desc == NULL)
                goto out;
@@ -424,11 +436,6 @@ static bool hidinput_setup_battery(struct hid_device *dev, unsigned report_type,
        psy_desc->use_for_apm = 0;
        psy_desc->get_property = hidinput_get_battery_property;
 
-       quirks = find_battery_quirk(dev);
-
-       hid_dbg(dev, "device %x:%x:%x %d quirks %d\n",
-               dev->bus, dev->vendor, dev->product, dev->version, quirks);
-
        min = field->logical_minimum;
        max = field->logical_maximum;