sbitmap: initialize weight to zero
authorColin Ian King <colin.king@canonical.com>
Mon, 19 Sep 2016 13:34:08 +0000 (14:34 +0100)
committerJens Axboe <axboe@fb.com>
Mon, 19 Sep 2016 14:19:40 +0000 (08:19 -0600)
Variable weight is not being initialized to zero before it is
used to compute the weight sum. Ensure it is initialized to zero.

Found with static analysis with cppcheck:
[lib/sbitmap.c:177]: (error) Uninitialized variable: weight

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
lib/sbitmap.c

index e408089..2cecf05 100644 (file)
@@ -169,7 +169,7 @@ EXPORT_SYMBOL_GPL(sbitmap_any_bit_clear);
 
 unsigned int sbitmap_weight(const struct sbitmap *sb)
 {
-       unsigned int i, weight;
+       unsigned int i, weight = 0;
 
        for (i = 0; i < sb->map_nr; i++) {
                const struct sbitmap_word *word = &sb->map[i];