scsi_sysfs: Fix typo in is_bin_visible()
authorHannes Reinecke <hare@suse.de>
Thu, 10 Mar 2016 10:25:26 +0000 (11:25 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 11 Mar 2016 01:29:54 +0000 (20:29 -0500)
The test for the existence vpd_pg83 is inverted.

Fixes: 7e47976bcff ("scsi_sysfs: add 'is_bin_visible' callback")
Signed-off-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Reported-by: Ewan Milne <emilne@redhat.com>
Reviewed-by: Laurence Oberman loberman@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_sysfs.c

index d164419..92ffd24 100644 (file)
@@ -1105,7 +1105,7 @@ static umode_t scsi_sdev_bin_attr_is_visible(struct kobject *kobj,
        if (attr == &dev_attr_vpd_pg80 && !sdev->vpd_pg80)
                return 0;
 
-       if (attr == &dev_attr_vpd_pg83 && sdev->vpd_pg83)
+       if (attr == &dev_attr_vpd_pg83 && !sdev->vpd_pg83)
                return 0;
 
        return S_IRUGO;