staging: rdma: hfi1: Remove useless return variables
authorBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Thu, 25 Feb 2016 11:52:11 +0000 (17:22 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 12 Mar 2016 06:09:09 +0000 (22:09 -0800)
This patch removes unnecessary return variables and compresses the
return logic.

The coccinelle script that finds and fixes this issue is:

@@ type T; identifier i,f; constant C; @@
- T i;
...when != i
when strict
( return -C;
|
- i =
+ return
f(...);
- return i;
)

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rdma/hfi1/chip.c

index 02ba78f..46a1830 100644 (file)
@@ -1250,11 +1250,8 @@ CNTR_ELEM(#name, \
 
 u64 read_csr(const struct hfi1_devdata *dd, u32 offset)
 {
-       u64 val;
-
        if (dd->flags & HFI1_PRESENT) {
-               val = readq((void __iomem *)dd->kregbase + offset);
-               return val;
+               return readq((void __iomem *)dd->kregbase + offset);
        }
        return -1;
 }