usb: misc: adutux: don't print error when allocating urb fails
authorWolfram Sang <wsa-dev@sang-engineering.com>
Thu, 11 Aug 2016 21:14:36 +0000 (23:14 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 15 Aug 2016 13:54:26 +0000 (15:54 +0200)
kmalloc will print enough information in case of failure.

Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/adutux.c

index 3071c0e..c34a0b6 100644 (file)
@@ -744,20 +744,16 @@ static int adu_probe(struct usb_interface *interface,
        memset(dev->interrupt_in_buffer, 'i', in_end_size);
 
        dev->interrupt_in_urb = usb_alloc_urb(0, GFP_KERNEL);
-       if (!dev->interrupt_in_urb) {
-               dev_err(&interface->dev, "Couldn't allocate interrupt_in_urb\n");
+       if (!dev->interrupt_in_urb)
                goto error;
-       }
        dev->interrupt_out_buffer = kmalloc(out_end_size, GFP_KERNEL);
        if (!dev->interrupt_out_buffer) {
                dev_err(&interface->dev, "Couldn't allocate interrupt_out_buffer\n");
                goto error;
        }
        dev->interrupt_out_urb = usb_alloc_urb(0, GFP_KERNEL);
-       if (!dev->interrupt_out_urb) {
-               dev_err(&interface->dev, "Couldn't allocate interrupt_out_urb\n");
+       if (!dev->interrupt_out_urb)
                goto error;
-       }
 
        if (!usb_string(udev, udev->descriptor.iSerialNumber, dev->serial_number,
                        sizeof(dev->serial_number))) {