perf symbols: Correct comment wrt kallsyms loading
authorCody P Schafer <cody@linux.vnet.ibm.com>
Fri, 10 Aug 2012 22:22:47 +0000 (15:22 -0700)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 13 Aug 2012 17:10:10 +0000 (14:10 -0300)
In kallsyms_parse() when calling process_symbol() (a callback argument
to kallsyms_parse()), we pass start as both start & end (ie:
start=start, end=start).

In map__process_kallsym_symbol(), the length is calculated as 'end -
start + 1', making the length 1, not 0.

Essentially, start & end define an inclusive range.

Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
Cc: David Hansen <dave@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Matt Hellsley <matthltc@us.ibm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/1344637382-22789-2-git-send-email-cody@linux.vnet.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/symbol.c

index 42c0d94..9f181a8 100644 (file)
@@ -605,7 +605,7 @@ int kallsyms__parse(const char *filename, void *arg,
 
                /*
                 * module symbols are not sorted so we add all
-                * symbols with zero length and rely on
+                * symbols, setting length to 1, and rely on
                 * symbols__fixup_end() to fix it up.
                 */
                err = process_symbol(arg, symbol_name,