libceph: move r_reply_op_{len,result} into struct ceph_osd_req_op
authorYan, Zheng <zyan@redhat.com>
Thu, 7 Jan 2016 08:48:57 +0000 (16:48 +0800)
committerIlya Dryomov <idryomov@gmail.com>
Fri, 25 Mar 2016 17:51:42 +0000 (18:51 +0100)
This avoids defining large array of r_reply_op_{len,result} in
in struct ceph_osd_request.

Signed-off-by: Yan, Zheng <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
drivers/block/rbd.c
include/linux/ceph/osd_client.h
net/ceph/osd_client.c

index 4a87678..94f31bd 100644 (file)
@@ -1854,7 +1854,7 @@ static void rbd_osd_req_callback(struct ceph_osd_request *osd_req,
         * passed to the block layer, which just supports a 32-bit
         * length field.
         */
-       obj_request->xferred = osd_req->r_reply_op_len[0];
+       obj_request->xferred = osd_req->r_ops[0].outdata_len;
        rbd_assert(obj_request->xferred < (u64)UINT_MAX);
 
        opcode = osd_req->r_ops[0].op;
index 35c8b00..c6d1d60 100644 (file)
@@ -78,6 +78,9 @@ struct ceph_osd_req_op {
        u16 op;           /* CEPH_OSD_OP_* */
        u32 flags;        /* CEPH_OSD_OP_FLAG_* */
        u32 indata_len;   /* request */
+       u32 outdata_len;  /* reply */
+       s32 rval;
+
        union {
                struct ceph_osd_data raw_data_in;
                struct {
@@ -148,8 +151,6 @@ struct ceph_osd_request {
        struct ceph_eversion *r_request_reassert_version;
 
        int               r_result;
-       int               r_reply_op_len[CEPH_OSD_MAX_OP];
-       s32               r_reply_op_result[CEPH_OSD_MAX_OP];
        int               r_got_reply;
        int               r_linger;
 
index 8407553..1048edb 100644 (file)
@@ -1821,7 +1821,7 @@ static void handle_reply(struct ceph_osd_client *osdc, struct ceph_msg *msg)
                int len;
 
                len = le32_to_cpu(op->payload_len);
-               req->r_reply_op_len[i] = len;
+               req->r_ops[i].outdata_len = len;
                dout(" op %d has %d bytes\n", i, len);
                payload_len += len;
                p += sizeof(*op);
@@ -1836,7 +1836,7 @@ static void handle_reply(struct ceph_osd_client *osdc, struct ceph_msg *msg)
        ceph_decode_need(&p, end, 4 + numops * 4, bad_put);
        retry_attempt = ceph_decode_32(&p);
        for (i = 0; i < numops; i++)
-               req->r_reply_op_result[i] = ceph_decode_32(&p);
+               req->r_ops[i].rval = ceph_decode_32(&p);
 
        if (le16_to_cpu(msg->hdr.version) >= 6) {
                p += 8 + 4; /* skip replay_version */