ARM: OMAP2+: hwmod: drop unnecessary list initialization
authorFelipe Balbi <balbi@ti.com>
Thu, 13 Nov 2014 16:36:55 +0000 (09:36 -0700)
committerPaul Walmsley <paul@pwsan.com>
Thu, 13 Nov 2014 16:36:55 +0000 (09:36 -0700)
ml->node and sl->node are currently initialized
by means of INIT_LIST_HEAD(). That initialiation
is followed by a list_add() call.

Looking at what both these functions do we will have:

ml->node.next = &ml->node;
ml->node.prev = &ml->node;
oi->master->master_ports.next.prev = &ml->node;
ml->node.next = &oi->master->master_ports.next;
ml->node.prev = &oi->master->master_ports;
oi->master->master_ports.next = &ml->node;

from this, it's clear that both INIT_LIST_HEAD() calls
are unnecessary and can be safely removed.

Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Paul Walmsley <paul@pwsan.com>
arch/arm/mach-omap2/omap_hwmod.c

index 716247e..acae6d5 100644 (file)
@@ -2832,12 +2832,10 @@ static int __init _add_link(struct omap_hwmod_ocp_if *oi)
        _alloc_links(&ml, &sl);
 
        ml->ocp_if = oi;
-       INIT_LIST_HEAD(&ml->node);
        list_add(&ml->node, &oi->master->master_ports);
        oi->master->masters_cnt++;
 
        sl->ocp_if = oi;
-       INIT_LIST_HEAD(&sl->node);
        list_add(&sl->node, &oi->slave->slave_ports);
        oi->slave->slaves_cnt++;