efi/esrt: Don't preformat name
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Fri, 20 Nov 2015 10:30:17 +0000 (11:30 +0100)
committerMatt Fleming <matt@codeblueprint.co.uk>
Mon, 14 Dec 2015 15:24:03 +0000 (15:24 +0000)
kobject_init_and_add takes a format string+args, so there's no reason
to do this formatting in advance.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Peter Jones <pjones@redhat.com>
Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk>
drivers/firmware/efi/esrt.c

index 22c5285..75feb3f 100644 (file)
@@ -167,14 +167,11 @@ static struct kset *esrt_kset;
 static int esre_create_sysfs_entry(void *esre, int entry_num)
 {
        struct esre_entry *entry;
-       char name[20];
 
        entry = kzalloc(sizeof(*entry), GFP_KERNEL);
        if (!entry)
                return -ENOMEM;
 
-       sprintf(name, "entry%d", entry_num);
-
        entry->kobj.kset = esrt_kset;
 
        if (esrt->fw_resource_version == 1) {
@@ -182,7 +179,7 @@ static int esre_create_sysfs_entry(void *esre, int entry_num)
 
                entry->esre.esre1 = esre;
                rc = kobject_init_and_add(&entry->kobj, &esre1_ktype, NULL,
-                                         "%s", name);
+                                         "entry%d", entry_num);
                if (rc) {
                        kfree(entry);
                        return rc;