crypto: ccp - Fix ccp_run_passthru_cmd dma variable assignments
authorDave Jones <davej@redhat.com>
Sun, 9 Feb 2014 01:59:14 +0000 (09:59 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sun, 9 Feb 2014 01:59:14 +0000 (09:59 +0800)
There are some suspicious looking lines of code in the new ccp driver, including
one that assigns a variable to itself, and another that overwrites a previous assignment.

This may have been a cut-and-paste error where 'src' was forgotten to be changed to 'dst'.
I have no hardware to test this, so this is untested.

Signed-off-by: Dave Jones <davej@fedoraproject.org>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/ccp/ccp-ops.c

index 71ed3ad..c266a7b 100644 (file)
@@ -1666,8 +1666,8 @@ static int ccp_run_passthru_cmd(struct ccp_cmd_queue *cmd_q,
 
                op.dst.type = CCP_MEMTYPE_SYSTEM;
                op.dst.u.dma.address = sg_dma_address(dst.sg_wa.sg);
-               op.src.u.dma.offset = dst.sg_wa.sg_used;
-               op.src.u.dma.length = op.src.u.dma.length;
+               op.dst.u.dma.offset = dst.sg_wa.sg_used;
+               op.dst.u.dma.length = op.src.u.dma.length;
 
                ret = ccp_perform_passthru(&op);
                if (ret) {