block: mark 1st parameter of bvec_iter_advance as const
authorMing Lei <ming.lei@canonical.com>
Mon, 30 May 2016 13:34:31 +0000 (21:34 +0800)
committerJens Axboe <axboe@fb.com>
Thu, 9 Jun 2016 16:02:47 +0000 (10:02 -0600)
bvec_iter_advance() only writes the parameter of iterator,
so the base address of bvec can be marked as const safely.

Without the change, we can see compiling warning in the
following patch for implementing iterate_bvec(): lib/iov_iter.c
with bvec iterator.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
Tested-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
include/linux/bvec.h

index 096efd2..701b64a 100644 (file)
@@ -66,7 +66,8 @@ struct bvec_iter {
        .bv_offset      = bvec_iter_offset((bvec), (iter)),     \
 })
 
-static inline void bvec_iter_advance(struct bio_vec *bv, struct bvec_iter *iter,
+static inline void bvec_iter_advance(const struct bio_vec *bv,
+                                    struct bvec_iter *iter,
                                     unsigned bytes)
 {
        WARN_ONCE(bytes > iter->bi_size,