ARM: pxa: Use kmalloc_array() in pxa_pm_init()
authorMarkus Elfring <elfring@users.sourceforge.net>
Thu, 25 Aug 2016 16:01:37 +0000 (18:01 +0200)
committerRobert Jarzmik <robert.jarzmik@free.fr>
Fri, 9 Sep 2016 16:08:00 +0000 (18:08 +0200)
* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kmalloc_array".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data type by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
arch/arm/mach-pxa/pm.c

index 388463b..e7450fb 100644 (file)
@@ -104,8 +104,9 @@ static int __init pxa_pm_init(void)
                return -EINVAL;
        }
 
-       sleep_save = kmalloc(pxa_cpu_pm_fns->save_count * sizeof(unsigned long),
-                            GFP_KERNEL);
+       sleep_save = kmalloc_array(pxa_cpu_pm_fns->save_count,
+                                  sizeof(*sleep_save),
+                                  GFP_KERNEL);
        if (!sleep_save) {
                printk(KERN_ERR "failed to alloc memory for pm save\n");
                return -ENOMEM;