fcoe: make sure fcoe frames are unshared prior to manipulating them
authorNeil Horman <nhorman@tuxdriver.com>
Sat, 3 Aug 2013 10:45:54 +0000 (10:45 +0000)
committerRobert Love <robert.w.love@intel.com>
Wed, 4 Sep 2013 19:33:08 +0000 (12:33 -0700)
Based on my last patch I noticed that fcoe_rcv has a simmilar problem, in that
it manipulates the passed in skb without checking to see if it has other users.
Making manipulations to a shared skb can result in various corruptions.

Easy fix, just make sure the skb is unshared prior to doing anything with it.

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
drivers/scsi/fcoe/fcoe.c

index 07453bb..f9b0302 100644 (file)
@@ -1452,6 +1452,12 @@ static int fcoe_rcv(struct sk_buff *skb, struct net_device *netdev,
                        skb_tail_pointer(skb), skb_end_pointer(skb),
                        skb->csum, skb->dev ? skb->dev->name : "<NULL>");
 
+
+       skb = skb_share_check(skb, GFP_ATOMIC);
+
+       if (skb == NULL)
+               return NET_RX_DROP;
+
        eh = eth_hdr(skb);
 
        if (is_fip_mode(ctlr) &&