netfilter: xt_osf: remove unused variable
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>
Tue, 23 Feb 2016 08:10:10 +0000 (13:40 +0530)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 29 Feb 2016 12:59:43 +0000 (13:59 +0100)
While building with W=1 we got the warning:
net/netfilter/xt_osf.c:265:9: warning: variable 'loop_cont' set but not used

The local variable loop_cont was only initialized and then assigned a
value but was never used or checked after that.
While removing the variable, the case of OSFOPT_TS was not removed so
that it will serve as a reminder to us that we can do something in that
particular case.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/xt_osf.c

index 4e3c3af..2455b69 100644 (file)
@@ -262,7 +262,6 @@ xt_osf_match_packet(const struct sk_buff *skb, struct xt_action_param *p)
                        if (f->opt[optnum].kind == (*optp)) {
                                __u32 len = f->opt[optnum].length;
                                const __u8 *optend = optp + len;
-                               int loop_cont = 0;
 
                                fmatch = FMATCH_OK;
 
@@ -275,7 +274,6 @@ xt_osf_match_packet(const struct sk_buff *skb, struct xt_action_param *p)
                                        mss = ntohs((__force __be16)mss);
                                        break;
                                case OSFOPT_TS:
-                                       loop_cont = 1;
                                        break;
                                }