ACPI / table: Replace '1' with specific error return values
authorHanjun Guo <hanjun.guo@linaro.org>
Thu, 5 Dec 2013 15:42:38 +0000 (23:42 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Sat, 7 Dec 2013 00:31:59 +0000 (01:31 +0100)
After commit 7f8f97c3cc (ACPI: acpi_table_parse() now returns
success/fail, not count), acpi_table_parse() returns '1' when it is
unable to find the table, but it should return a negative error code
in that case.  Make it return -ENODEV instead.

Fix the same problem in acpi_table_init() analogously.

Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
[rjw: Subject and changelog]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/tables.c

index d67a1fe..4ec4425 100644 (file)
@@ -306,7 +306,7 @@ int __init acpi_table_parse(char *id, acpi_tbl_table_handler handler)
                early_acpi_os_unmap_memory(table, tbl_size);
                return 0;
        } else
-               return 1;
+               return -ENODEV;
 }
 
 /* 
@@ -351,7 +351,7 @@ int __init acpi_table_init(void)
 
        status = acpi_initialize_tables(initial_tables, ACPI_MAX_TABLES, 0);
        if (ACPI_FAILURE(status))
-               return 1;
+               return -EINVAL;
 
        check_multiple_madt();
        return 0;