power: ab8500_charger: Remove deprecated create_singlethread_workqueue
authorBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Sat, 13 Aug 2016 16:21:23 +0000 (21:51 +0530)
committerSebastian Reichel <sre@kernel.org>
Mon, 15 Aug 2016 22:54:37 +0000 (00:54 +0200)
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.

The workqueue "charger_wq" is used for the IRQs and checking HW state of
the charger. It has been identity converted.

It has multiple work items viz usb_charger_attached_work, kick_wd_work,
check_vbat_work, check_hw_failure_work, usb_charger_attached_work,
ac_work, ac_charger_attached_work, attach_work and check_usbchgnotok_work,
which require execution ordering. Hence, a dedicated ordered workqueue
has been used here.

The WQ_MEM_RECLAIM flag has also been set to ensure
forward progress under memory pressure.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
drivers/power/supply/ab8500_charger.c

index 30de5d4..5cee9aa 100644 (file)
@@ -3540,8 +3540,8 @@ static int ab8500_charger_probe(struct platform_device *pdev)
        di->usb_state.usb_current = -1;
 
        /* Create a work queue for the charger */
-       di->charger_wq =
-               create_singlethread_workqueue("ab8500_charger_wq");
+       di->charger_wq = alloc_ordered_workqueue("ab8500_charger_wq",
+                                                WQ_MEM_RECLAIM);
        if (di->charger_wq == NULL) {
                dev_err(di->dev, "failed to create work queue\n");
                return -ENOMEM;