cpufreq: governor: Check transition latecy at init time only
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 13 May 2016 23:00:28 +0000 (01:00 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 30 May 2016 12:34:16 +0000 (14:34 +0200)
It is not necessary to check the governor's max_transition_latency
attribute every time cpufreq_governor() runs, so check it only if
the event argument is CPUFREQ_GOV_POLICY_INIT.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/cpufreq.c

index e3e6661..a5f1d01 100644 (file)
@@ -2011,23 +2011,24 @@ static int cpufreq_governor(struct cpufreq_policy *policy, unsigned int event)
        if (!policy->governor)
                return -EINVAL;
 
-       if (policy->governor->max_transition_latency &&
-           policy->cpuinfo.transition_latency >
-           policy->governor->max_transition_latency) {
-               struct cpufreq_governor *gov = cpufreq_fallback_governor();
-
-               if (gov) {
-                       pr_warn("%s governor failed, too long transition latency of HW, fallback to %s governor\n",
-                               policy->governor->name, gov->name);
-                       policy->governor = gov;
-               } else {
-                       return -EINVAL;
+       if (event == CPUFREQ_GOV_POLICY_INIT) {
+               if (policy->governor->max_transition_latency &&
+                   policy->cpuinfo.transition_latency >
+                   policy->governor->max_transition_latency) {
+                       struct cpufreq_governor *gov = cpufreq_fallback_governor();
+
+                       if (gov) {
+                               pr_warn("%s governor failed, too long transition latency of HW, fallback to %s governor\n",
+                                       policy->governor->name, gov->name);
+                               policy->governor = gov;
+                       } else {
+                               return -EINVAL;
+                       }
                }
-       }
 
-       if (event == CPUFREQ_GOV_POLICY_INIT)
                if (!try_module_get(policy->governor->owner))
                        return -EINVAL;
+       }
 
        pr_debug("%s: for CPU %u, event %u\n", __func__, policy->cpu, event);