i2c: i801: Drop needless bit-wise OR
authorJean Delvare <jdelvare@suse.de>
Wed, 25 May 2016 07:37:02 +0000 (09:37 +0200)
committerWolfram Sang <wsa@the-dreams.de>
Mon, 13 Jun 2016 20:32:09 +0000 (22:32 +0200)
The interrupt handling code makes it look like several status values
may be merged together before being processed, while this will never
happen. Change from bit-wise OR to simple assignment to make it more
obvious and avoid misunderstanding.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-i801.c

index 4a60ad2..b436963 100644 (file)
@@ -547,7 +547,7 @@ static irqreturn_t i801_isr(int irq, void *dev_id)
        status &= SMBHSTSTS_INTR | STATUS_ERROR_FLAGS;
        if (status) {
                outb_p(status, SMBHSTSTS(priv));
-               priv->status |= status;
+               priv->status = status;
                wake_up(&priv->waitq);
        }