xen/arm: use BUG_ON
authorHimangi Saraogi <himangi774@gmail.com>
Fri, 25 Jul 2014 16:05:39 +0000 (12:05 -0400)
committerKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Fri, 25 Jul 2014 16:05:48 +0000 (12:05 -0400)
Use BUG_ON(x) rather than if(x) BUG();

The semantic patch that fixes this problem is as follows:

// <smpl>
@@ identifier x; @@
-if (x) BUG();
+BUG_ON(x);
// </smpl>

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
arch/arm/xen/enlighten.c

index 1e63243..98544c5 100644 (file)
@@ -181,8 +181,7 @@ static void xen_restart(enum reboot_mode reboot_mode, const char *cmd)
        struct sched_shutdown r = { .reason = SHUTDOWN_reboot };
        int rc;
        rc = HYPERVISOR_sched_op(SCHEDOP_shutdown, &r);
-       if (rc)
-               BUG();
+       BUG_ON(rc);
 }
 
 static void xen_power_off(void)
@@ -190,8 +189,7 @@ static void xen_power_off(void)
        struct sched_shutdown r = { .reason = SHUTDOWN_poweroff };
        int rc;
        rc = HYPERVISOR_sched_op(SCHEDOP_shutdown, &r);
-       if (rc)
-               BUG();
+       BUG_ON(rc);
 }
 
 static int xen_cpu_notification(struct notifier_block *self,