spi: fsl-espi: simplify of_fsl_espi_probe
authorHeiner Kallweit <heiner.kallweit@web.de>
Sat, 17 Sep 2016 13:43:00 +0000 (15:43 +0200)
committerMark Brown <broonie@kernel.org>
Sat, 24 Sep 2016 18:48:31 +0000 (19:48 +0100)
Simplify of_fsl_espi_probe.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-fsl-espi.c

index 4f9d9ec..dee3f82 100644 (file)
@@ -685,7 +685,7 @@ static int of_fsl_espi_probe(struct platform_device *ofdev)
        struct spi_master *master;
        struct resource mem;
        unsigned int irq;
-       int ret = -ENOMEM;
+       int ret;
 
        ret = of_mpc8xxx_spi_probe(ofdev);
        if (ret)
@@ -693,28 +693,21 @@ static int of_fsl_espi_probe(struct platform_device *ofdev)
 
        ret = of_fsl_espi_get_chipselects(dev);
        if (ret)
-               goto err;
+               return ret;
 
        ret = of_address_to_resource(np, 0, &mem);
        if (ret)
-               goto err;
+               return ret;
 
        irq = irq_of_parse_and_map(np, 0);
-       if (!irq) {
-               ret = -EINVAL;
-               goto err;
-       }
+       if (!irq)
+               return -EINVAL;
 
        master = fsl_espi_probe(dev, &mem, irq);
-       if (IS_ERR(master)) {
-               ret = PTR_ERR(master);
-               goto err;
-       }
+       if (IS_ERR(master))
+               return PTR_ERR(master);
 
        return 0;
-
-err:
-       return ret;
 }
 
 static int of_fsl_espi_remove(struct platform_device *dev)